This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-backoffice-ui.git
from b6cc8f2f Merge pull request #694 from
Aman-Mittal/feat/non-admin-loan-flows-and-security-adapters
add a3004df1 fix(rbac): gate transaction routes on the code each command
needs
add 4a8016f0 fix(rbac): name permission codes the platform actually defines
add 7afc70ef test(e2e): cover savings duties under non-admin roles, and
invert the loan gate assertions
add e8aac9b6 test(e2e): reopen the savings view after an action, which
redirects to the list
add c2f0bdd0 fix(savings): require the payment type a deposit cannot be
made without
add 2c27faaf fix(scripts): stop disabling certificate validation to
refresh the snapshot
add 30d9b91a fix(ci): download each comment artifact by name, so the
diagram comment appears
add 7bb71137 test: retarget the office transactions dead-end at the door
it now closes
new f49c276c Merge pull request #695 from
Aman-Mittal/fix/route-permissions-per-command
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/scripts/post-e2e-comments.js | 55 +-
.github/workflows/ci.yml | 6 +
.github/workflows/pr-comments.yml | 57 +-
DOCS/CI_CHECKS.md | 27 +-
e2e/loan-flows-non-admin-roles.spec.ts | 372 +++--------
e2e/rbac-dead-end-controls.spec.ts | 26 +-
e2e/savings-flows-non-admin-roles.spec.ts | 361 ++++++++++
e2e/utils/ui-rbac.ts | 283 ++++++++
package.json | 2 +
playwright.config.ts | 1 +
scripts/check-permission-codes.mjs | 168 +++++
scripts/check-route-permissions.mjs | 120 +++-
scripts/fetch-permission-codes.sh | 51 ++
scripts/permission-codes.json | 738 +++++++++++++++++++++
scripts/pr-comment-actions.test.mjs | 237 ++++++-
scripts/snapshot-permission-codes.mjs | 137 ++++
src/app/core/guards/command-permissions.test.ts | 115 ++++
src/app/core/guards/command-permissions.ts | 150 +++++
src/app/core/guards/permission.guard.test.ts | 101 ++-
src/app/core/guards/permission.guard.ts | 30 +-
src/app/core/services/navigation-config.service.ts | 3 +-
src/app/features/clients/client-view.component.ts | 4 +-
src/app/features/loans/loan-view.component.ts | 17 +-
src/app/features/loans/loans.routes.ts | 6 +-
.../office-transactions-list.component.test.ts | 122 ++++
.../features/organization/organization.routes.ts | 22 +-
src/app/features/products/products.routes.ts | 7 +-
.../savings-account-transaction-form.component.ts | 14 +
.../products/savings-account-view.component.ts | 16 +-
29 files changed, 2914 insertions(+), 334 deletions(-)
create mode 100644 e2e/savings-flows-non-admin-roles.spec.ts
create mode 100644 e2e/utils/ui-rbac.ts
create mode 100644 scripts/check-permission-codes.mjs
create mode 100644 scripts/fetch-permission-codes.sh
create mode 100644 scripts/permission-codes.json
create mode 100644 scripts/snapshot-permission-codes.mjs
create mode 100644 src/app/core/guards/command-permissions.test.ts
create mode 100644 src/app/core/guards/command-permissions.ts
create mode 100644
src/app/features/organization/office-transactions/office-transactions-list.component.test.ts
