This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-consumer-facing.git
from bd16bef Merge pull request #171 from Aman-Mittal/build/static-analysis
add 4325be9 refactor(frontend): reach the BFF and Ionic overlays through
adapter ports
add f339102 build(frontend): enforce the adapter boundary in lint
add 981e4d8 docs(frontend): describe the adapter boundary
add e1cafa2 style(frontend): merge split imports flagged by
import-x/no-duplicates
new 74079f7 Merge pull request #169 from
Aman-Mittal/refactor/frontend-adapter-boundary
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
AGENTS.md | 1 +
docs/frontend/architecture/adapter-boundary.adoc | 87 +++++++++++++
docs/frontend/architecture/bff-integration.adoc | 2 +-
docs/frontend/architecture/index.adoc | 4 +-
docs/frontend/architecture/overview.adoc | 4 +-
docs/frontend/architecture/state-management.adoc | 11 +-
frontend/eslint-rules/no-generated-api-import.js | 120 ++++++++++++++++++
.../eslint-rules/no-generated-api-import.test.js | 111 +++++++++++++++++
frontend/eslint.config.js | 56 +++++++++
.../adapters/api/audit.api.ts} | 45 +++----
.../adapters/api/auth.api.ts} | 49 ++++----
.../src/app/core/adapters/api/beneficiary.api.ts | 64 ++++++++++
.../api/bff-audit.api.ts} | 25 ++--
.../adapters/api/bff-auth.api.ts} | 40 +++---
.../adapters/api/bff-beneficiary.api.ts} | 41 +++----
.../adapters/api/bff-consent.api.ts} | 33 +++--
frontend/src/app/core/adapters/api/bff-loan.api.ts | 125 +++++++++++++++++++
.../src/app/core/adapters/api/bff-mappers.spec.ts | 135 +++++++++++++++++++++
.../adapters/api/bff-page.ts} | 39 +++---
.../adapters/api/bff-registration.api.ts} | 13 +-
.../src/app/core/adapters/api/bff-savings.api.ts | 75 ++++++++++++
.../src/app/core/adapters/api/bff-summary.api.ts | 62 ++++++++++
.../src/app/core/adapters/api/bff-transfer.api.ts | 56 +++++++++
frontend/src/app/core/adapters/api/bff-user.api.ts | 81 +++++++++++++
frontend/src/app/core/adapters/api/consent.api.ts | 39 ++++++
frontend/src/app/core/adapters/api/loan.api.ts | 95 +++++++++++++++
.../css/actions.scss => core/adapters/api/page.ts} | 29 ++---
.../adapters/api/registration.api.ts} | 46 +++----
frontend/src/app/core/adapters/api/savings.api.ts | 56 +++++++++
frontend/src/app/core/adapters/api/summary.api.ts | 58 +++++++++
frontend/src/app/core/adapters/api/transfer.api.ts | 53 ++++++++
frontend/src/app/core/adapters/api/user.api.ts | 74 +++++++++++
frontend/src/app/core/adapters/index.ts | 57 +++++++++
.../adapters/overlay/ionic-overlay.adapter.spec.ts | 72 +++++++++++
.../core/adapters/overlay/ionic-overlay.adapter.ts | 45 +++++++
.../app/core/adapters/overlay/overlay.adapter.ts | 59 +++++++++
frontend/src/app/core/audit/audit.service.ts | 2 +-
frontend/src/app/core/auth/auth.service.ts | 15 +--
.../core/interceptors/error.interceptor.spec.ts | 18 ++-
.../src/app/core/interceptors/error.interceptor.ts | 22 ++--
.../app/core/notifications/notification.service.ts | 18 ++-
.../auth/forgot-password.component.spec.ts | 8 +-
.../app/features/auth/forgot-password.component.ts | 18 +--
.../beneficiaries/beneficiaries.component.spec.ts | 9 +-
.../beneficiaries/beneficiaries.component.ts | 19 ++-
.../beneficiaries/beneficiaries.store.spec.ts | 12 +-
.../features/beneficiaries/beneficiaries.store.ts | 29 ++---
frontend/src/app/features/demo/demo.store.spec.ts | 12 +-
frontend/src/app/features/demo/demo.store.ts | 8 +-
.../src/app/features/loans/loan-apply.component.ts | 2 +-
.../features/loans/loan-repay.component.spec.ts | 2 +-
.../src/app/features/loans/loans.store.spec.ts | 13 +-
frontend/src/app/features/loans/loans.store.ts | 85 ++++++-------
.../src/app/features/profile/profile.store.spec.ts | 12 +-
frontend/src/app/features/profile/profile.store.ts | 38 +++---
.../registration/registration.component.ts | 2 +-
.../registration/registration.service.spec.ts | 12 +-
.../features/registration/registration.service.ts | 12 +-
.../src/app/features/savings/savings.store.spec.ts | 12 +-
frontend/src/app/features/savings/savings.store.ts | 56 ++++-----
.../features/settings/change-password.component.ts | 19 +--
.../app/features/settings/settings.component.ts | 2 +-
.../app/features/settings/settings.store.spec.ts | 12 +-
.../src/app/features/settings/settings.store.ts | 27 ++---
.../src/app/features/summary/summary.store.spec.ts | 12 +-
frontend/src/app/features/summary/summary.store.ts | 52 +-------
.../transfers/transfer-form.component.spec.ts | 2 +-
.../app/features/transfers/transfers.store.spec.ts | 12 +-
.../src/app/features/transfers/transfers.store.ts | 31 ++---
.../src/app/testing/bff-api-testing.ts | 37 +++---
frontend/tsconfig.app.json | 3 +-
71 files changed, 1997 insertions(+), 610 deletions(-)
create mode 100644 docs/frontend/architecture/adapter-boundary.adoc
create mode 100644 frontend/eslint-rules/no-generated-api-import.js
create mode 100644 frontend/eslint-rules/no-generated-api-import.test.js
copy frontend/src/app/{features/registration/registration.service.ts =>
core/adapters/api/audit.api.ts} (50%)
copy frontend/src/app/{features/registration/registration.service.ts =>
core/adapters/api/auth.api.ts} (50%)
create mode 100644 frontend/src/app/core/adapters/api/beneficiary.api.ts
copy frontend/src/app/core/{auth/device-fingerprint.ts =>
adapters/api/bff-audit.api.ts} (62%)
copy frontend/src/app/{features/registration/registration.service.ts =>
core/adapters/api/bff-auth.api.ts} (51%)
copy frontend/src/app/{features/beneficiaries/beneficiaries.store.ts =>
core/adapters/api/bff-beneficiary.api.ts} (59%)
copy frontend/src/app/{features/registration/registration.service.ts =>
core/adapters/api/bff-consent.api.ts} (56%)
create mode 100644 frontend/src/app/core/adapters/api/bff-loan.api.ts
create mode 100644 frontend/src/app/core/adapters/api/bff-mappers.spec.ts
copy frontend/src/app/{shared/css/centered-page.scss =>
core/adapters/api/bff-page.ts} (57%)
copy frontend/src/app/{features/registration/registration.service.ts =>
core/adapters/api/bff-registration.api.ts} (83%)
create mode 100644 frontend/src/app/core/adapters/api/bff-savings.api.ts
create mode 100644 frontend/src/app/core/adapters/api/bff-summary.api.ts
create mode 100644 frontend/src/app/core/adapters/api/bff-transfer.api.ts
create mode 100644 frontend/src/app/core/adapters/api/bff-user.api.ts
create mode 100644 frontend/src/app/core/adapters/api/consent.api.ts
create mode 100644 frontend/src/app/core/adapters/api/loan.api.ts
copy frontend/src/app/{shared/css/actions.scss => core/adapters/api/page.ts}
(65%)
copy frontend/src/app/{features/registration/registration.service.ts =>
core/adapters/api/registration.api.ts} (56%)
create mode 100644 frontend/src/app/core/adapters/api/savings.api.ts
create mode 100644 frontend/src/app/core/adapters/api/summary.api.ts
create mode 100644 frontend/src/app/core/adapters/api/transfer.api.ts
create mode 100644 frontend/src/app/core/adapters/api/user.api.ts
create mode 100644 frontend/src/app/core/adapters/index.ts
create mode 100644
frontend/src/app/core/adapters/overlay/ionic-overlay.adapter.spec.ts
create mode 100644
frontend/src/app/core/adapters/overlay/ionic-overlay.adapter.ts
create mode 100644 frontend/src/app/core/adapters/overlay/overlay.adapter.ts
copy
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/correlation/service/CorrelationIdHolder.java
=> frontend/src/app/testing/bff-api-testing.ts (50%)
