This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-consumer-facing.git
from 4a5a762 Merge pull request #205 from
Kollishion/fix/frontend-i18n-storage-adapters
add 331b8c1 refactor(transfers): move feign clients behind
TransferFineractClient gateway
add ed9b2eb feat(transfers): validate loan overpayment and active status
on repayments (#114) - validate destination loan is active and payment does not
exceed prepayLoan payoff amount - return HTTP 422 with
TransferLoanOverpaymentException or TransferLoanNotActiveException - add unit
tests covering overpayment, boundary equal to payoff, and inactive loan
rejection - add Cucumber overpayment scenario asserting HTTP 422 and error code
- update transfers.adoc documentation and add fro [...]
new 23f6a5c Merge pull request #204 from
ayushcodes27/feat/114-loan-payment-limit
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../data/LoanPayoffData.java} | 11 +-
.../TransferFineractClient.java} | 25 ++-
.../service/TransferFineractClientImpl.java | 91 +++++++++
...on.java => TransferLoanNotActiveException.java} | 8 +-
....java => TransferLoanOverpaymentException.java} | 8 +-
.../service/TransfersCommandServiceImpl.java | 41 ++--
.../consumer/cucumber/steps/TransfersSteps.java | 42 ++++
.../service/TransferFineractClientImplTest.java | 174 +++++++++++++++++
.../service/TransfersCommandServiceImplTest.java | 211 ++++++++++++++++-----
...e-generated-fineract-feign-clients-fd283b04.txt | 10 -
.../src/test/resources/features/transfers.feature | 4 +
docs/consumer/features/transfers.adoc | 10 +-
frontend/public/i18n/en.json | 4 +-
frontend/public/i18n/hi.json | 4 +-
14 files changed, 539 insertions(+), 104 deletions(-)
copy
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/{exception/ConsumerApiError.java
=> fineractclient/data/LoanPayoffData.java} (77%)
copy
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/fineractclient/{interceptors/FineractTenantHeaderInterceptor.java
=> service/TransferFineractClient.java} (63%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/fineractclient/service/TransferFineractClientImpl.java
copy
consumer/src/main/java/org/apache/fineract/consumer/transfers/command/exception/{TransferStepUpInvalidException.java
=> TransferLoanNotActiveException.java} (81%)
copy
consumer/src/main/java/org/apache/fineract/consumer/transfers/command/exception/{TransferStepUpInvalidException.java
=> TransferLoanOverpaymentException.java} (80%)
create mode 100644
consumer/src/test/java/org/apache/fineract/consumer/infrastructure/fineractclient/service/TransferFineractClientImplTest.java