This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


    from e7d381590b Merge pull request #6778 from Bhavya-Sonigra/FINERACT-3019
     add 968eab3cae FINERACT-2967: move the shared test extensions and global 
configuration helper to feign
     add 41a097b9ee FINERACT-2967: move the delinquency bucket and range calls 
to feign
     add 6fef897e75 FINERACT-2967: create test clients through the feign client 
helper
     add 31f436f87a FINERACT-2967: move the remaining test helper calls to feign
     add 34d79d9fc4 FINERACT-2967: remove the legacy test helpers left without 
callers
     add cb1ad5ca74 FINERACT-2967: document the charges of a fixed deposit 
application
     add ae69ed33e5 FINERACT-2967: migrate DateValidationTest to feign
     add e9c496efa0 FINERACT-2967: remove the legacy helpers DateValidationTest 
was the last user of
     add 0ec3dadf32 FINERACT-2967: document the share and interop payloads the 
migrated tests use
     add 2f071a7630 FINERACT-2967: migrate the share tests to feign
     add 8757b621ed FINERACT-2967: migrate InteropTest to feign
     add 2edca319b4 FINERACT-2967: remove the last REST Assured test helpers
     add a750e01905 FINERACT-2967: create the floating rate loan product 
through the feign client
     add d89b4934a1 FINERACT-2967: let the feign client send requests without 
basic credentials
     add 6e4a27186d FINERACT-2967: document the two-factor authentication 
payloads
     add f5df8bb10e FINERACT-2967: migrate the oauth2 and two-factor 
authentication tests to feign
     add c832db5e24 FINERACT-2967: send the created user's credentials in the 
batch reschedule steps
     add 0189970fbd FINERACT-2967: drop REST Assured and the Retrofit SDK from 
the test modules
     new a8d90159df Merge pull request #6797 from 
adamsaghy/FINERACT-2967/finish-feign-migration

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .agents/skills/fineract-testing/SKILL.md           |    8 +-
 .../groovy/org.apache.fineract.dependencies.gradle |    6 -
 config/checkstyle/checkstyle.xml                   |   10 +-
 config/checkstyle/restassured-baseline.xml         |   95 -
 .../fineract/client/feign/FineractFeignClient.java |   11 +
 .../client/feign/FineractFeignClientConfig.java    |   23 +-
 .../feign/FineractFeignClientConfigTest.java       |    9 +
 .../FineractFeignClientIntegrationTest.java        |   30 +
 .../en/chapters/testing/integration-feign.adoc     |   50 +-
 .../src/docs/en/chapters/testing/integration.adoc  |   28 +-
 fineract-e2e-tests-core/build.gradle               |    1 -
 .../apache/fineract/test/helper/ErrorResponse.java |   11 -
 .../test/stepdef/common/BatchApiStepDef.java       |   31 +-
 fineract-e2e-tests-runner/build.gradle             |    1 -
 .../api/LoanProductsApiResourceSwagger.java        |   12 +
 .../data/InteropIdentifierRequestData.java         |    4 +
 .../accounts/api/AccountsApiResourceSwagger.java   |   12 +-
 .../products/api/ProductsApiResourceSwagger.java   |    9 +-
 .../FixedDepositAccountsApiResourceSwagger.java    |   18 +
 .../api/ShareDividendApiResource.java              |   13 +-
 .../api/ShareDividendApiResourceSwagger.java       |  121 +
 .../api/AuthenticationApiResourceSwagger.java      |    2 +
 .../security/api/TwoFactorApiResource.java         |   13 +-
 .../security/api/TwoFactorApiResourceSwagger.java  |   94 +
 .../api/TwoFactorConfigurationApiResource.java     |   10 +-
 .../TwoFactorConfigurationApiResourceSwagger.java  |   97 +
 integration-tests/README.md                        |    4 +-
 integration-tests/dependencies.gradle              |   10 -
 ...ansferOfficeHierarchyAccessIntegrationTest.java |    9 +-
 ...PaymentAllocationLoanRepaymentScheduleTest.java |   62 +-
 .../BatchWorkingCapitalLoanIntegrationTest.java    |   12 +-
 .../integrationtests/CenterIntegrationTest.java    |    5 +-
 .../integrationtests/DateValidationTest.java       |  188 +-
 .../DelinquencyAndChargebackIntegrationTest.java   |   11 +-
 .../ExternalBusinessEventTest.java                 |    6 +-
 .../ExternalIdSupportIntegrationTest.java          |   42 +-
 .../FloatingRateInterestRecalculationTest.java     |   49 +-
 .../integrationtests/GlobalConfigurationTest.java  |   75 +-
 .../fineract/integrationtests/GroupTest.java       |    2 -
 .../InstanceModeIntegrationTest.java               |    8 +-
 ...ChargeOffWithAdvancedPaymentAllocationTest.java |   31 +-
 ...eseReplayWithAdvancedPaymentAllocationTest.java |   29 +-
 ...ccountCreditRefundPayoutWithChargebackTest.java |   11 +-
 ...AccountDisbursementToSavingsAccountingTest.java |   16 +-
 ...sbursementToSavingsWithAutoDownPaymentTest.java |   12 +-
 .../integrationtests/LoanAccountFraudTest.java     |    4 +-
 ...nsactionOnDisbursementByAccountingTypeTest.java |   14 +-
 .../LoanAccrualTransactionReversalTest.java        |   13 +-
 ...gEntriesForReverseReplayedTransactionsTest.java |   11 +-
 ...gePaymentWithAdvancedPaymentAllocationTest.java |   17 +-
 ...backOnPaymentTypeRepaymentTransactionsTest.java |   15 +-
 ...ncyDetailsNextPaymentDateConfigurationTest.java |   13 +-
 .../LoanDelinquencyForNonActiveAccountsTest.java   |   23 +-
 .../LoanDownPaymentTransactionTypeTest.java        |    7 +-
 .../LoanInterestRecalculationCOBTest.java          |    4 +-
 .../integrationtests/LoanInterestRefundTest.java   |    4 +-
 ...nManualInterestRefundResponseStructureTest.java |    4 +-
 .../LoanOfficeHierarchyAccessIntegrationTest.java  |    9 +-
 .../LoanPostChargeOffScenariosTest.java            |   35 +-
 .../LoanProductBasicDetailsTest.java               |    7 +-
 .../integrationtests/LoanProductTemplateTest.java  |    7 +-
 ...hAdvancedPaymentAllocationIntegrationTests.java |   12 +-
 ...oanProductWithDownPaymentConfigurationTest.java |   11 +-
 .../LoanRefundTransactionTest.java                 |   10 +-
 ...paymentScheduleForChargesAfterMaturityTest.java |   12 +-
 .../LoanRepaymentScheduleWithDownPaymentTest.java  |   73 +-
 .../fineract/integrationtests/LoanSummaryTest.java |   13 +-
 .../LoanTransactionChargebackTest.java             |   17 +-
 ...ionFullAmountChargebackForOverpaidLoanTest.java |   11 +-
 .../LoanTransactionInterestPaymentWaiverTest.java  |   24 +-
 .../LoanTransactionReverseReplayChargeOffTest.java |    4 +-
 .../LoanTransactionReverseReplayRelationTest.java  |    7 +-
 .../LoanTransactionReverseReplayTest.java          |    8 +-
 .../integrationtests/LoanWaiveChargeTest.java      |    8 +-
 .../MultiActivityAccrualsTest.java                 |    4 +-
 .../PaymentTypeIntegrationTest.java                |    4 +-
 ...epositOfficeHierarchyAccessIntegrationTest.java |    9 +-
 .../RepaymentReverseExternalIdTest.java            |   12 +-
 .../RepaymentWithPostDatedChecksTest.java          |    9 +-
 ...avingsOfficeHierarchyAccessIntegrationTest.java |    9 +-
 .../ShareProductDatatableIntegrationTest.java      |   61 +-
 ...qlInjectionReportingServiceIntegrationTest.java |    3 +-
 .../StandingInstructionLoanAccountTest.java        |   14 +-
 .../integrationtests/TaxComponentEditLockTest.java |   12 +-
 .../TaxGroupComponentEndDateChangeTest.java        |    5 +-
 .../TaxGroupComponentEndDateTest.java              |    5 +-
 .../TaxGroupComponentStartDateTest.java            |    5 +-
 .../TaxGroupEditAfterComponentEndedTest.java       |    5 +-
 .../TaxGroupMixedComponentUpdateTest.java          |    5 +-
 .../fineract/integrationtests/TaxesTest.java       |    7 +-
 ...ndoRepaymentWithDownPaymentIntegrationTest.java |   19 +-
 .../WorkingCapitalLoanApplicationCRUDTest.java     |   22 +-
 ...orkingCapitalLoanApplicationValidationTest.java |   13 +-
 .../WorkingCapitalLoanApprovalRejectionTest.java   |    7 +-
 .../WorkingCapitalLoanBreachActionTest.java        |    6 +-
 .../WorkingCapitalLoanBreachPastDueAmountTest.java |    6 +-
 ...rkingCapitalLoanBreachResetDuringPauseTest.java |    6 +-
 .../WorkingCapitalLoanChargeOffAccountingTest.java |    6 +-
 .../WorkingCapitalLoanCreditBalanceRefundTest.java |    6 +-
 ...lLoanDelinquencyActionEffectiveEndDateTest.java |   12 +-
 ...apitalLoanDelinquencyActionIntegrationTest.java |   12 +-
 ...pitalLoanDelinquencyDisableIntegrationTest.java |   20 +-
 ...oanDelinquencyRangeScheduleIntegrationTest.java |   16 +-
 .../WorkingCapitalLoanDisbursementTest.java        |   15 +-
 ...apitalLoanDiscountFeeAmortizationDriftTest.java |    7 +-
 .../WorkingCapitalLoanEirValidationTest.java       |    8 +-
 .../WorkingCapitalLoanMarkAsFraudTest.java         |    7 +-
 .../WorkingCapitalLoanNearBreachConfigTest.java    |    6 +-
 .../WorkingCapitalLoanOriginatorsTest.java         |    6 +-
 .../WorkingCapitalLoanProductCRUDTest.java         |    5 +-
 ...ngCapitalLoanRecoveryPaymentAccountingTest.java |    6 +-
 .../WorkingCapitalLoanRepaymentAccountingTest.java |    6 +-
 .../WorkingCapitalLoanRepaymentTest.java           |    6 +-
 .../WorkingCapitalLoanStartDatesTest.java          |   16 +-
 ...rkingCapitalLoanTransactionPaymentTypeTest.java |    7 +-
 .../WorkingCapitalLoanWriteOffAccountingTest.java  |    6 +-
 .../client/feign/FeignLoanTestBase.java            |   29 +-
 .../client/feign/FeignWorkingCapitalTestBase.java  |    8 +-
 .../feign/helpers/ClientIdentifierCommandsApi.java |    7 +-
 .../CreditBureauIntegrationCommandsApi.java        |    6 +-
 .../feign/helpers/ExternalServiceCommandsApi.java  |    4 +-
 .../client/feign/helpers/FeignClientHelper.java    |    2 +-
 .../feign/helpers/FeignDelinquencyHelper.java      |   48 +-
 .../FeignFinancialActivityAccountHelper.java       |    4 +
 .../feign/helpers/FeignFixedDepositHelper.java     |    6 +
 .../helpers/FeignGlobalConfigurationHelper.java    |   26 +-
 .../client/feign/helpers/FeignInteropHelper.java   |  188 ++
 .../client/feign/helpers/FeignLoanHelper.java      |    4 +
 .../feign/helpers/FeignPaymentTypeHelper.java      |    5 +
 .../feign/helpers/FeignShareAccountHelper.java     |  124 +-
 ...Api.java => InteropTransactionRequestsApi.java} |   17 +-
 .../feign/helpers/LoanProductCommandsApi.java      |   12 +-
 .../feign/helpers/ShareAccountCommandsApi.java     |   28 +-
 .../client/feign/modules/LoanProductTemplates.java |    4 +-
 ...ignOfficeSpecificLoanProductVisibilityTest.java |    9 +-
 ...nWorkingCapitalLoanChargeAfterMaturityTest.java |    7 +-
 .../FeignWorkingCapitalLoanParentClearTest.java    |    5 +-
 ...rkingCapitalLoanRepaymentBackdatedUndoTest.java |    7 +-
 ...kingCapitalLoanRepaymentBeforeFirstCobTest.java |    7 +-
 .../FeignWorkingCapitalLoanStatusHelpersTest.java  |    7 +-
 .../common/BusinessDateHelper.java                 |    9 +-
 .../common/BusinessStepHelper.java                 |   66 -
 .../integrationtests/common/CenterDomain.java      |  276 --
 .../integrationtests/common/CenterHelper.java      |  379 ---
 .../integrationtests/common/ClientHelper.java      |  457 ---
 .../common/CollateralManagementHelper.java         |  207 --
 .../common/ExternalAssetOwnerHelper.java           |  132 -
 .../common/ExternalEventConfigurationHelper.java   |   88 -
 .../common/FineractClientHelper.java               |   58 -
 .../common/GlobalConfigurationHelper.java          |  142 +-
 .../integrationtests/common/GroupHelper.java       |  369 ---
 .../integrationtests/common/NotesHelper.java       |  227 --
 .../integrationtests/common/PaymentTypeHelper.java |   68 -
 .../fineract/integrationtests/common/Utils.java    |  232 +-
 .../common/accounting/AccountHelper.java           |  187 --
 .../common/accounting/AccountingRuleBuilder.java   |   58 -
 .../accounting/FinancialActivityAccountHelper.java |   86 -
 .../FinancialActivityAccountsMappingBuilder.java   |   36 -
 .../common/accounting/GLAccountBuilder.java        |  106 -
 .../common/accounting/JournalEntryHelper.java      |   93 -
 .../common/charges/ChargesHelper.java              |  532 ----
 .../common/error/ErrorResponse.java                |   15 -
 .../externalevents/ExternalEventsExtension.java    |   44 +-
 .../fixeddeposit/FixedDepositAccountHelper.java    |  621 ----
 .../fixeddeposit/FixedDepositProductHelper.java    |  550 ----
 .../integrationtests/common/funds/FundsHelper.java |  106 -
 .../common/funds/FundsResourceHandler.java         |   56 -
 .../common/loans/LoanCOBCatchUpHelper.java         |   62 -
 .../common/loans/LoanProductHelper.java            |   63 -
 .../common/loans/LoanStatusChecker.java            |   70 -
 .../common/loans/LoanTestLifecycleExtension.java   |   48 +-
 .../common/loans/LoanTransactionHelper.java        | 3154 --------------------
 .../common/organisation/StaffHelper.java           |  123 -
 .../common/products/DelinquencyBucketsHelper.java  |  127 -
 .../common/products/DelinquencyRangesHelper.java   |   54 -
 .../common/report/ReportHelper.java                |   32 -
 .../common/savings/AccountTransferHelper.java      |  214 --
 .../common/savings/SavingsAccountHelper.java       | 1360 ---------
 .../savings/SavingsApplicationTestBuilder.java     |  122 -
 .../common/savings/SavingsProductHelper.java       |  470 ---
 .../common/savings/SavingsStatusChecker.java       |  148 -
 .../savings/SavingsTestLifecycleExtension.java     |   42 +-
 .../common/savings/SavingsTransactionData.java     |   57 -
 .../common/shares/DividendsIntegrationTests.java   |  232 +-
 .../common/shares/ShareAccountHelper.java          |  117 -
 .../shares/ShareAccountIntegrationTests.java       | 1530 ++++------
 .../shares/ShareAccountTransactionHelper.java      |   73 -
 .../shares/ShareDividendsTransactionHelper.java    |   75 -
 .../common/shares/ShareProductHelper.java          |  259 --
 .../shares/ShareProductTransactionHelper.java      |   63 -
 .../integrationtests/common/system/CodeHelper.java |  256 --
 .../common/system/DatatableHelper.java             |  264 --
 .../guarantor/GuarantorHelper.java                 |  117 -
 .../guarantor/GuarantorTestBuilder.java            |   98 -
 .../interoperation/InteropHelper.java              |  460 ---
 .../interoperation/InteropTest.java                |  263 +-
 .../integrationtests/investor/InvestorHelper.java  |   41 -
 .../InitiateExternalAssetOwnerTransferTest.java    |    4 +-
 .../support/instancemode/InstanceModeHelper.java   |   25 +-
 .../instancemode/InstanceModeSupportExtension.java |   44 +-
 ...VariableInstallmentsDecliningBalanceHelper.java |  407 ---
 .../VariableInstallmentsFlatHelper.java            |  298 --
 .../VariableIntallmentsTransactionHelper.java      |   72 -
 oauth2-tests/dependencies.gradle                   |    6 +-
 .../oauth2tests/OAuth2AuthenticationTest.java      |  169 +-
 twofactor-tests/dependencies.gradle                |    6 +-
 .../TwoFactorAuthenticationTest.java               |  327 +-
 207 files changed, 2834 insertions(+), 16401 deletions(-)
 delete mode 100644 config/checkstyle/restassured-baseline.xml
 create mode 100644 
fineract-provider/src/main/java/org/apache/fineract/portfolio/shareproducts/api/ShareDividendApiResourceSwagger.java
 create mode 100644 
fineract-security/src/main/java/org/apache/fineract/infrastructure/security/api/TwoFactorApiResourceSwagger.java
 create mode 100644 
fineract-security/src/main/java/org/apache/fineract/infrastructure/security/api/TwoFactorConfigurationApiResourceSwagger.java
 create mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/FeignInteropHelper.java
 copy 
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/{StaffCommandsApi.java
 => InteropTransactionRequestsApi.java} (67%)
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/BusinessStepHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/CenterDomain.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/CenterHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/CollateralManagementHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ExternalAssetOwnerHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ExternalEventConfigurationHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/FineractClientHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/GroupHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/NotesHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/PaymentTypeHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/AccountHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/AccountingRuleBuilder.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/FinancialActivityAccountHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/FinancialActivityAccountsMappingBuilder.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/GLAccountBuilder.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/accounting/JournalEntryHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/charges/ChargesHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/fixeddeposit/FixedDepositAccountHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/fixeddeposit/FixedDepositProductHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/funds/FundsHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/funds/FundsResourceHandler.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanCOBCatchUpHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanProductHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanStatusChecker.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanTransactionHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/organisation/StaffHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/products/DelinquencyBucketsHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/products/DelinquencyRangesHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/report/ReportHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/AccountTransferHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsAccountHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsApplicationTestBuilder.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsProductHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsStatusChecker.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsTransactionData.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareAccountHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareAccountTransactionHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareDividendsTransactionHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareProductHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareProductTransactionHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/system/CodeHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/system/DatatableHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/guarantor/GuarantorHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/guarantor/GuarantorTestBuilder.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/interoperation/InteropHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/investor/InvestorHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/variableinstallments/VariableInstallmentsDecliningBalanceHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/variableinstallments/VariableInstallmentsFlatHelper.java
 delete mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/variableinstallments/VariableIntallmentsTransactionHelper.java

Reply via email to