This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


    from 684a36849b Merge pull request #6861 from 
renovate-bot/renovate/com.puppycrawl.tools-checkstyle-14.x
     add da0714fe5e FINERACT-3004: Run COB business steps in the item writer
     add aa76e346cc FINERACT-3004: Remove the COB retry limit and pin a single 
attempt
     add 9fbaf85d28 FINERACT-3004: Refuse a JDBC REQUIRES_NEW transaction 
inside a JPA one
     add 69d7a9cff3 FINERACT-3004: Add an integration test for a failing COB 
business step
     add 566fcbeff3 FINERACT-3004: Drop static imports the test base class 
already provides
     add 241492c20a FINERACT-3004: Close the remaining COB failure paths found 
in review
     add 3fab25691d FINERACT-3004: Credit the failing-business-step scenario to 
its author
     add 52a85803b4 FINERACT-3004: Keep deferred COB error saves on their 
tenant and drop the redundant saveAll
     add 023da8e1ea FINERACT-3004: Record a COB error only once the account's 
outcome is final
     add e2553d6062 FINERACT-3004: Leave the JDBC transaction-manager change to 
its own PR
     new d8ffb56948 Merge pull request #6847 from 
adamsaghy/fix/loan-cob-skip-batch6

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../fineract/cob/COBBusinessStepServiceImpl.java   |  27 +-
 .../cob/exceptions/COBAccountFailedException.java  |  49 +++
 .../cob/listener/AbstractLoanItemListener.java     | 150 +++++--
 .../cob/processor/AbstractItemProcessor.java       |  76 ----
 .../fineract/cob/writer/AbstractCOBItemWriter.java | 163 ++++++++
 .../core/config/FineractProperties.java            |   4 +-
 .../core/persistence/AfterTransactionWork.java     | 126 ++++++
 .../ExtendedDataSourceTransactionManager.java      |   2 +
 .../persistence/ExtendedJpaTransactionManager.java |   2 +
 .../springbatch/PropertyService.java               |   2 -
 .../springbatch/StepRetryPolicyFactory.java        |  43 +-
 .../core/persistence/AfterTransactionWorkTest.java | 116 ++++++
 .../docs/en/chapters/architecture/batch-jobs.adoc  |  16 +-
 .../listener/ChunkProcessingLoanItemListener.java  |   7 +-
 .../cob/listener/InlineCOBLoanItemListener.java    |   7 +-
 .../cob/loan/AbstractLoanItemProcessor.java        |  56 ---
 .../fineract/cob/loan/AbstractLoanItemReader.java  |  34 +-
 .../fineract/cob/loan/AbstractLoanItemWriter.java  |  44 +-
 .../cob/loan/InlineCOBLoanItemProcessor.java       |  37 --
 .../fineract/cob/loan/InlineCOBLoanItemReader.java |   8 +-
 .../fineract/cob/loan/InlineCOBLoanItemWriter.java |  18 +-
 .../cob/loan/LoanCOBWorkerConfiguration.java       |  47 +--
 .../fineract/cob/loan/LoanInlineCOBConfig.java     |  27 +-
 .../fineract/cob/loan/LoanItemProcessor.java       |  37 --
 .../apache/fineract/cob/loan/LoanItemReader.java   |  10 +-
 .../apache/fineract/cob/loan/LoanItemWriter.java   |  18 +-
 .../WorkingCapitalInlineCOBLoanItemReader.java     |   8 +-
 .../loan/WorkingCapitalLoanInlineCOBConfig.java    |  31 +-
 .../springbatch/FineractJobRepository.java         |   2 +-
 .../springbatch/PropertyServiceImpl.java           |   5 -
 .../src/main/resources/application.properties      |  12 +-
 .../ChunkProcessingLoanItemListenerTest.java       | 188 +++++++++
 .../listener/LoanItemListenerStepDefinitions.java  |  23 +-
 .../apache/fineract/cob/loan/CobNoRetryTest.java   | 225 +++++++++++
 .../cob/loan/CobStepListenerRegistrationTest.java  |  12 +-
 .../cob/loan/LoanItemProcessorStepDefinitions.java |  92 -----
 .../cob/loan/LoanItemReaderStepDefinitions.java    |  24 +-
 .../fineract/cob/loan/LoanItemReaderTest.java      |  50 +--
 .../cob/loan/LoanItemWriterStepDefinitions.java    |  67 ----
 .../fineract/cob/loan/LoanItemWriterTest.java      | 197 +++++++++
 .../fineract/cob/writer/COBWriterScanModeTest.java | 442 +++++++++++++++++++++
 .../fineract/cob/writer/probe/CobProbeAccount.java |  44 +-
 .../writer/probe/CobProbeAccountRepository.java}   |   4 +-
 .../AfterTransactionWorkConnectionTest.java        | 199 ++++++++++
 .../SpringBatchPropertyServiceDefinitions.java     |   9 -
 .../src/test/resources/application-test.properties |   1 -
 .../cob/listener/cob.loan.item.listener.feature    |  10 -
 .../features/cob/loan/cob.loan.processor.feature   |  39 --
 .../features/cob/loan/cob.loan.reader.feature      |   4 +-
 .../features/cob/loan/cob.loan.writer.feature      |  39 --
 .../infrastructure.springbatch.feature             |   4 -
 ...kingCapitalChunkProcessingLoanItemListener.java |   7 +-
 ...ctWorkingCapitalLoanCOBWorkerItemProcessor.java |  58 ---
 ...tractWorkingCapitalLoanCOBWorkerItemWriter.java |  49 ++-
 ...ineWorkingCapitalLoanCOBWorkerItemListener.java |   7 +-
 ...nlineWorkingCapitalLoanCOBWorkerItemWriter.java |  22 +-
 .../WorkingCapitalLoanCOBWorkerConfiguration.java  |  41 +-
 .../WorkingCapitalLoanCOBWorkerItemListener.java   |   7 +-
 .../WorkingCapitalLoanCOBWorkerItemProcessor.java  |  37 --
 .../WorkingCapitalLoanCOBWorkerItemReader.java     |  26 +-
 .../WorkingCapitalLoanCOBWorkerItemWriter.java     |  21 +-
 ...ingCapitalLoanInlineCOBWorkerItemProcessor.java |  37 --
 .../WorkingCapitalLoanCOBWorkerStepScopeTest.java  |  21 +-
 .../LoanCobBusinessStepFailureTest.java            | 152 +++++++
 64 files changed, 2302 insertions(+), 1040 deletions(-)
 create mode 100644 
fineract-cob/src/main/java/org/apache/fineract/cob/exceptions/COBAccountFailedException.java
 delete mode 100644 
fineract-cob/src/main/java/org/apache/fineract/cob/processor/AbstractItemProcessor.java
 create mode 100644 
fineract-cob/src/main/java/org/apache/fineract/cob/writer/AbstractCOBItemWriter.java
 create mode 100644 
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/persistence/AfterTransactionWork.java
 create mode 100644 
fineract-core/src/test/java/org/apache/fineract/infrastructure/core/persistence/AfterTransactionWorkTest.java
 delete mode 100644 
fineract-provider/src/main/java/org/apache/fineract/cob/loan/AbstractLoanItemProcessor.java
 delete mode 100644 
fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineCOBLoanItemProcessor.java
 delete mode 100644 
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanItemProcessor.java
 create mode 100644 
fineract-provider/src/test/java/org/apache/fineract/cob/listener/ChunkProcessingLoanItemListenerTest.java
 create mode 100644 
fineract-provider/src/test/java/org/apache/fineract/cob/loan/CobNoRetryTest.java
 delete mode 100644 
fineract-provider/src/test/java/org/apache/fineract/cob/loan/LoanItemProcessorStepDefinitions.java
 delete mode 100644 
fineract-provider/src/test/java/org/apache/fineract/cob/loan/LoanItemWriterStepDefinitions.java
 create mode 100644 
fineract-provider/src/test/java/org/apache/fineract/cob/loan/LoanItemWriterTest.java
 create mode 100644 
fineract-provider/src/test/java/org/apache/fineract/cob/writer/COBWriterScanModeTest.java
 copy 
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/ProgressiveLoanModel.java
 => 
fineract-provider/src/test/java/org/apache/fineract/cob/writer/probe/CobProbeAccount.java
 (55%)
 copy 
fineract-provider/src/{main/java/org/apache/fineract/notification/domain/NotificationRepository.java
 => 
test/java/org/apache/fineract/cob/writer/probe/CobProbeAccountRepository.java} 
(86%)
 create mode 100644 
fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/persistence/AfterTransactionWorkConnectionTest.java
 delete mode 100644 
fineract-provider/src/test/resources/features/cob/loan/cob.loan.processor.feature
 delete mode 100644 
fineract-provider/src/test/resources/features/cob/loan/cob.loan.writer.feature
 delete mode 100644 
fineract-working-capital-loan/src/main/java/org/apache/fineract/cob/workingcapitalloan/AbstractWorkingCapitalLoanCOBWorkerItemProcessor.java
 delete mode 100644 
fineract-working-capital-loan/src/main/java/org/apache/fineract/cob/workingcapitalloan/WorkingCapitalLoanCOBWorkerItemProcessor.java
 delete mode 100644 
fineract-working-capital-loan/src/main/java/org/apache/fineract/cob/workingcapitalloan/WorkingCapitalLoanInlineCOBWorkerItemProcessor.java
 create mode 100644 
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanCobBusinessStepFailureTest.java

Reply via email to