This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git
commit 8c23e73c7a9163954dcd0c229fa79c667a21aed2 Merge: c20329359e 67d935cccb Author: Adam Saghy <[email protected]> AuthorDate: Thu Nov 19 10:50:10 2026 +0000 Merge pull request #6167 from aditinikam/FINERACT-2240 FINERACT-2240: migrate Charges to CommandDispatcher fineract-charge/dependencies.gradle | 2 + .../portfolio/charge/api/ChargesApiResource.java | 104 ++-- .../charge/api/ChargesApiResourceSwagger.java | 349 ------------ .../ChargeCreateCommand.java} | 19 +- .../ChargeDeleteCommand.java} | 19 +- .../ChargeUpdateCommand.java} | 19 +- .../portfolio/charge/data/ChargeCreateRequest.java | 98 ++++ .../ChargeCreateResponse.java} | 23 +- .../ChargeDeleteRequest.java} | 21 +- .../ChargeDeleteResponse.java} | 23 +- .../portfolio/charge/data/ChargeUpdateRequest.java | 107 ++++ .../ChargeUpdateResponse.java} | 25 +- .../fineract/portfolio/charge/domain/Charge.java | 443 +-------------- .../portfolio/charge/domain/ChargeRepository.java | 12 + .../charge/handler/ChargeCreateCommandHandler.java | 51 ++ .../charge/handler/ChargeDeleteCommandHandler.java | 51 ++ .../charge/handler/ChargeUpdateCommandHandler.java | 51 ++ .../CreateChargeDefinitionCommandHandler.java | 42 -- .../DeleteChargeDefinitionCommandHandler.java | 42 -- .../UpdateChargeDefinitionCommandHandler.java | 42 -- .../portfolio/charge/request/ChargeRequest.java | 61 --- ...geDefinitionCommandFromApiJsonDeserializer.java | 605 --------------------- ...PlatformService.java => ChargeReadService.java} | 2 +- ...latformService.java => ChargeWriteService.java} | 19 +- .../validation/ChargeAmortizationValidator.java | 143 +++++ .../charge/validation/ChargeCreateValidator.java | 169 ++++++ .../charge/validation/ChargeRulesChecker.java | 115 ++++ .../charge/validation/ChargeUpdateValidator.java | 208 +++++++ .../ValidChargeCreate.java} | 20 +- .../ValidChargeUpdate.java} | 20 +- .../portfolio/charge/domain/ChargeTest.java | 153 ------ .../ChargeAmortizationConfigurationTest.java | 307 ----------- ...finitionCommandFromApiJsonDeserializerTest.java | 64 --- .../charge/validation/ChargeValidationTest.java | 564 +++++++++++++++++++ .../commands/service/CommandWrapperBuilder.java | 25 - .../WorkingCapitalChargeRequestFactory.java | 6 +- ...talLoanProductAdvancedAccountingTestHelper.java | 8 +- .../stepdef/loan/ChargeAmortizationStepDef.java | 28 +- .../fineract/test/stepdef/loan/ChargeStepDef.java | 32 +- .../stepdef/loan/WorkingCapitalChargeStepDef.java | 27 +- .../global/ChargeGlobalInitializerStep.java | 15 +- .../features/LoanChargesDownPayment.feature | 10 +- .../features/WorkingCapitalLoanCharge.feature | 16 +- .../BulkImportWorkbookPopulatorServiceImpl.java | 13 +- .../infrastructure/core/config/SecurityConfig.java | 12 + ...ServiceImpl.java => ChargeReadServiceImpl.java} | 2 +- ...hargeWritePlatformServiceJpaRepositoryImpl.java | 306 ----------- .../charge/service/ChargeWriteServiceImpl.java | 562 +++++++++++++++++++ .../charge/starter/ChargeConfiguration.java | 28 +- .../client/api/ClientChargesApiResource.java | 6 +- .../loanaccount/api/LoanChargesApiResource.java | 6 +- .../loanaccount/api/LoansApiResource.java | 12 +- .../service/LoanReadPlatformServiceImpl.java | 10 +- .../starter/LoanAccountConfiguration.java | 6 +- .../loanproduct/api/LoanProductsApiResource.java | 8 +- .../LoanProductReadPlatformServiceImpl.java | 6 +- .../starter/LoanProductConfiguration.java | 6 +- .../api/FixedDepositProductsApiResource.java | 10 +- .../api/RecurringDepositProductsApiResource.java | 10 +- .../api/SavingsAccountChargesApiResource.java | 7 +- .../savings/api/SavingsProductsApiResource.java | 10 +- .../DepositAccountReadPlatformServiceImpl.java | 14 +- ...ingsAccountTemplateReadPlatformServiceImpl.java | 18 +- .../savings/starter/SavingsConfiguration.java | 10 +- .../ShareAccountReadPlatformServiceImpl.java | 11 +- .../start/ShareAccountsConfiguration.java | 11 +- .../ShareProductReadPlatformServiceImpl.java | 10 +- .../starter/ShareProductsConfiguration.java | 6 +- .../src/main/resources/application.properties | 20 + ...BulkImportWorkbookPopulatorServiceImplTest.java | 4 +- ...eWritePlatformServiceJpaRepositoryImplTest.java | 108 ---- .../charge/service/ChargeWriteServiceImplTest.java | 521 ++++++++++++++++++ ...ansApiResourceRetrieveApprovalTemplateTest.java | 4 +- ...nProductsApiResourceTemplateDatatablesTest.java | 4 +- .../api/SavingsAccountChargesApiResourceTest.java | 4 +- .../main/resources/ValidationMessages.properties | 48 ++ .../api/WorkingCapitalLoanChargesApiResource.java | 6 +- .../AccrualsOnLoanClosureTest.java | 12 +- .../ChargeAmortizationConfigurationTest.java | 28 +- .../fineract/integrationtests/ChargesTest.java | 112 ++-- .../integrationtests/ClientChargeRoundingTest.java | 16 +- .../ClientLoanIntegrationTest.java | 10 +- ...DueDateRespectiveLoanRepaymentScheduleTest.java | 4 +- .../LoanCOBAccountLockCatchupInlineCOBTest.java | 4 +- .../LoanCatchUpIntegrationTest.java | 4 +- .../LoanChargeProgressiveTest.java | 6 +- .../integrationtests/LoanChargeRoundingTest.java | 68 +-- .../LoanChargeSpecificDueDateTest.java | 4 +- .../LoanChargeTaxIntegrationTest.java | 38 +- .../LoanChargesMultipleDebitAccountsTest.java | 60 +- .../LoanInterestRecalculationCOBTest.java | 6 +- .../LoanRepaymentScheduleWithDownPaymentTest.java | 10 +- ...LoanSpecificDueDateChargeAfterMaturityTest.java | 4 +- .../LoanTransactionAccrualActivityPostingTest.java | 8 +- .../LoanTransactionInterestPaymentWaiverTest.java | 6 +- .../integrationtests/LoanWaiveChargeTest.java | 12 +- ...chantIssuedRefundAdditionalInstallmentTest.java | 4 +- .../ProgressiveLoanUndoDisbursementTest.java | 6 +- .../SavingsAccountChargeRoundingTest.java | 24 +- .../SavingsAccountChargeUpdateTest.java | 16 +- .../integrationtests/SchedulerJobsTestResults.java | 12 +- .../ShareAccountChargeRoundingTest.java | 56 +- .../integrationtests/TaxComponentEditLockTest.java | 4 +- .../TaxGroupComponentStartDateTest.java | 4 +- ...ingCapitalLoanTransactionSummaryReportTest.java | 12 +- .../importhandler/loan/LoanImportHandlerTest.java | 4 +- .../client/feign/FeignLoanTestBase.java | 10 +- .../client/feign/helpers/FeignChargesHelper.java | 50 +- .../feign/helpers/FeignSavingsChargeHelper.java | 8 +- .../helpers/FeignWorkingCapitalLoanHelper.java | 8 +- .../feign/modules/ChargeRequestBuilders.java | 47 +- .../feign/modules/SavingsRequestBuilders.java | 30 +- .../modules/WorkingCapitalLoanRequestBuilders.java | 37 +- .../FeignCobBulkEventRecordingWindowTest.java | 8 +- ...ignOfficeSpecificLoanProductVisibilityTest.java | 4 +- .../FeignWorkingCapitalChargeProductTest.java | 107 ++-- .../integrationtests/cob/CobPartitioningTest.java | 4 +- .../shares/ShareAccountIntegrationTests.java | 4 +- .../inlinecob/InlineLoanCOBTest.java | 4 +- .../LoanPenaltyBackdatedTransactionTest.java | 8 +- .../loan/reaging/LoanReAgingIntegrationTest.java | 4 +- .../savings/AccountTransferWithdrawalFeeTest.java | 6 +- 122 files changed, 3578 insertions(+), 3294 deletions(-)
