revert addition of removeItem to IList. It was breaking third-party Ilist impls, including LCDS DataList
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/31d79802 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/31d79802 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/31d79802 Branch: refs/heads/master Commit: 31d79802de18ae00c33e419f8345d04c4969eae7 Parents: fd4451c Author: Alex Harui <aha...@apache.org> Authored: Mon Jul 29 08:36:12 2013 -0700 Committer: Alex Harui <aha...@apache.org> Committed: Mon Jul 29 08:36:12 2013 -0700 ---------------------------------------------------------------------- .../src/spark/components/DataNavigator.as | 4 +++- .../src/spark/components/DataNavigatorGroup.as | 4 +++- .../projects/framework/src/mx/collections/IList.as | 14 -------------- .../src/mx/collections/ListCollectionView.as | 4 +++- .../spark/src/spark/collections/SubListView.as | 2 +- 5 files changed, 10 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/31d79802/frameworks/projects/experimental/src/spark/components/DataNavigator.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/experimental/src/spark/components/DataNavigator.as b/frameworks/projects/experimental/src/spark/components/DataNavigator.as index 78987fb..86d2214 100644 --- a/frameworks/projects/experimental/src/spark/components/DataNavigator.as +++ b/frameworks/projects/experimental/src/spark/components/DataNavigator.as @@ -1024,7 +1024,9 @@ package spark.components */ public function removeItem( item:Object ):Boolean { - return dataProvider.removeItem( item ); + if ("removeItem" in dataProvider) + return dataProvider["removeItem"]( item ); + return false; } /** http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/31d79802/frameworks/projects/experimental/src/spark/components/DataNavigatorGroup.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/experimental/src/spark/components/DataNavigatorGroup.as b/frameworks/projects/experimental/src/spark/components/DataNavigatorGroup.as index 03172f8..3267b10 100644 --- a/frameworks/projects/experimental/src/spark/components/DataNavigatorGroup.as +++ b/frameworks/projects/experimental/src/spark/components/DataNavigatorGroup.as @@ -482,7 +482,9 @@ package spark.components */ public function removeItem( item:Object ):Boolean { - return dataProvider.removeItem(item); + if ("removeItem" in dataProvider) + return dataProvider["removeItem"]( item ); + return false; } /** http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/31d79802/frameworks/projects/framework/src/mx/collections/IList.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/framework/src/mx/collections/IList.as b/frameworks/projects/framework/src/mx/collections/IList.as index e636a7d..4c40ad4 100644 --- a/frameworks/projects/framework/src/mx/collections/IList.as +++ b/frameworks/projects/framework/src/mx/collections/IList.as @@ -213,20 +213,6 @@ public interface IList extends IEventDispatcher */ function removeAll():void; - /** - * Removes the specified item from this list, should it exist. - * Relies on ArrayList implementation - * - * @param item Object reference to the item that should be removed. - * @return Boolean indicating if the item was removed. - * - * @langversion 3.0 - * @playerversion Flash 9 - * @playerversion AIR 1.1 - * @productversion Apache Flex 4.10 - */ - function removeItem( item:Object ):Boolean; - /** * Removes the item at the specified index and returns it. * Any items that were after this index are now one index earlier. http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/31d79802/frameworks/projects/framework/src/mx/collections/ListCollectionView.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/framework/src/mx/collections/ListCollectionView.as b/frameworks/projects/framework/src/mx/collections/ListCollectionView.as index 6dc1a2f..95acb60 100644 --- a/frameworks/projects/framework/src/mx/collections/ListCollectionView.as +++ b/frameworks/projects/framework/src/mx/collections/ListCollectionView.as @@ -806,7 +806,9 @@ public class ListCollectionView extends Proxy */ public function removeItem(item:Object):Boolean { - return list.removeItem(item); + if ("removeItem" in list) + return list["removeItem"](item); + return false; } /** http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/31d79802/frameworks/projects/spark/src/spark/collections/SubListView.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/spark/src/spark/collections/SubListView.as b/frameworks/projects/spark/src/spark/collections/SubListView.as index c6ababf..ea7ea67 100644 --- a/frameworks/projects/spark/src/spark/collections/SubListView.as +++ b/frameworks/projects/spark/src/spark/collections/SubListView.as @@ -381,7 +381,7 @@ public class SubListView extends EventDispatcher implements IList public function removeItem(item:Object):Boolean { - return (list) ? list.removeItem( item ) : false; + return (list && "removeItem" in list) ? list["removeItem"]( item ) : false; } public function removeItemAt(index:int):Object
