http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/CapitalizeConstantsRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/CapitalizeConstantsRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/CapitalizeConstantsRuleTest.java index 6be17b1..d660a2b 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/CapitalizeConstantsRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/CapitalizeConstantsRuleTest.java @@ -20,27 +20,24 @@ import com.adobe.ac.pmd.rules.core.AbstractAstFlexRuleTest; import com.adobe.ac.pmd.rules.core.AbstractFlexRule; import com.adobe.ac.pmd.rules.core.ViolationPosition; -public class CapitalizeConstantsRuleTest extends AbstractAstFlexRuleTest -{ - @Override - protected ExpectedViolation[] getExpectedViolatingFiles() - { - return new ExpectedViolation[] - { new ExpectedViolation( "AbstractRowData.as", new ViolationPosition[] - { new ViolationPosition( 45 ), - new ViolationPosition( 46 ) } ), - new ExpectedViolation( "bug.FlexPMD233b.mxml", new ViolationPosition[] - { new ViolationPosition( 66 ) } ), - new ExpectedViolation( "com.adobe.ac.ncss.ArrayVO.as", new ViolationPosition[] - { new ViolationPosition( 39 ), - new ViolationPosition( 40 ) } ), - new ExpectedViolation( "GenericType.as", new ViolationPosition[] - { new ViolationPosition( 36 ) } ) }; - } +public class CapitalizeConstantsRuleTest extends AbstractAstFlexRuleTest { + @Override + protected ExpectedViolation[] getExpectedViolatingFiles() { + return new ExpectedViolation[] + {new ExpectedViolation("AbstractRowData.as", new ViolationPosition[] + {new ViolationPosition(33), + new ViolationPosition(34)}), + new ExpectedViolation("bug.FlexPMD233b.mxml", new ViolationPosition[] + {new ViolationPosition(52)}), + new ExpectedViolation("com.adobe.ac.ncss.ArrayVO.as", new ViolationPosition[] + {new ViolationPosition(27), + new ViolationPosition(28)}), + new ExpectedViolation("GenericType.as", new ViolationPosition[] + {new ViolationPosition(24)})}; + } - @Override - protected AbstractFlexRule getRule() - { - return new CapitalizeConstantsRule(); - } + @Override + protected AbstractFlexRule getRule() { + return new CapitalizeConstantsRule(); + } }
http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectClassCaseTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectClassCaseTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectClassCaseTest.java index 12b2dd0..9695d76 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectClassCaseTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectClassCaseTest.java @@ -27,7 +27,7 @@ public class IncorrectClassCaseTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "com.adobe.ac.foo.as", new ViolationPosition[] - { new ViolationPosition( 1, 34 ) } ) }; + { new ViolationPosition( 1, 22 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectEventHandlerNameRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectEventHandlerNameRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectEventHandlerNameRuleTest.java index c6d998d..c8765f9 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectEventHandlerNameRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/IncorrectEventHandlerNameRuleTest.java @@ -27,16 +27,16 @@ public class IncorrectEventHandlerNameRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Duane.mxml", new ViolationPosition[] - { new ViolationPosition( 71 ) } ), + { new ViolationPosition( 57 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.MyCairngormCommand.as", new ViolationPosition[] - { new ViolationPosition( 35 ) } ), + { new ViolationPosition( 23 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.NestedSwitch.as", new ViolationPosition[] - { new ViolationPosition( 35 ) } ), + { new ViolationPosition( 23 ) } ), new ExpectedViolation( "parsley.InaccessibleMetaData.as", new ViolationPosition[] - { new ViolationPosition( 54 ), - new ViolationPosition( 60 ) } ), + { new ViolationPosition( 42 ), + new ViolationPosition( 48 ) } ), new ExpectedViolation( "Sorted.as", new ViolationPosition[] - { new ViolationPosition( 71 ) } ) }; + { new ViolationPosition( 59 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/InterfaceNamingRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/InterfaceNamingRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/InterfaceNamingRuleTest.java index b9cd65a..feeded8 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/InterfaceNamingRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/InterfaceNamingRuleTest.java @@ -27,12 +27,12 @@ public class InterfaceNamingRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "Color.as", new ViolationPosition[] - { new ViolationPosition( 35 ) } ), + { new ViolationPosition( 23 ) } ), new ExpectedViolation( "src.fw.data.request.ResultListener.as", new ViolationPosition[] - { new ViolationPosition( 33 ) } ), + { new ViolationPosition( 21 ) } ), new ExpectedViolation( "org.as3commons.concurrency.thread.Color.as", new ViolationPosition[] - { new ViolationPosition( 33 ) } ) }; + { new ViolationPosition( 21 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PackageCaseRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PackageCaseRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PackageCaseRuleTest.java index bf901fd..bb340fd 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PackageCaseRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PackageCaseRuleTest.java @@ -19,7 +19,9 @@ package com.adobe.ac.pmd.rules.naming; import com.adobe.ac.pmd.rules.core.AbstractAstFlexRuleTest; import com.adobe.ac.pmd.rules.core.AbstractFlexRule; import com.adobe.ac.pmd.rules.core.ViolationPosition; +import org.junit.Ignore; +@Ignore("This test requires test-data that was not donated to Apache") public class PackageCaseRuleTest extends AbstractAstFlexRuleTest { @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PropertyHiddenByLocalVariableRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PropertyHiddenByLocalVariableRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PropertyHiddenByLocalVariableRuleTest.java index 0acbb32..abab7db 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PropertyHiddenByLocalVariableRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/PropertyHiddenByLocalVariableRuleTest.java @@ -27,7 +27,7 @@ public class PropertyHiddenByLocalVariableRuleTest extends AbstractAstFlexRuleTe { return new ExpectedViolation[] { new ExpectedViolation( "com.adobe.ac.ncss.VoidConstructor.as", new ViolationPosition[] - { new ViolationPosition( 40 ) } ) }; + { new ViolationPosition( 28 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooLongFunctionNameRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooLongFunctionNameRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooLongFunctionNameRuleTest.java index a5e67a0..3eef64d 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooLongFunctionNameRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooLongFunctionNameRuleTest.java @@ -27,7 +27,7 @@ public class TooLongFunctionNameRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "flexunit.RulesetTest.as", new ViolationPosition[] - { new ViolationPosition( 53 ) } ) }; + { new ViolationPosition( 41 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooShortVariableRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooShortVariableRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooShortVariableRuleTest.java index ca187cd..ebcceee 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooShortVariableRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/TooShortVariableRuleTest.java @@ -27,19 +27,19 @@ public class TooShortVariableRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Duane.mxml", new ViolationPosition[] - { new ViolationPosition( 68 ) } ), + { new ViolationPosition( 54 ) } ), new ExpectedViolation( "bug.FlexPMD233b.mxml", new ViolationPosition[] - { new ViolationPosition( 102 ) } ), + { new ViolationPosition( 88 ) } ), new ExpectedViolation( "flexpmd114.a.Test.as", new ViolationPosition[] - { new ViolationPosition( 42 ) } ), + { new ViolationPosition( 30 ) } ), new ExpectedViolation( "flexpmd114.b.Test.as", new ViolationPosition[] - { new ViolationPosition( 42 ) } ), + { new ViolationPosition( 30 ) } ), new ExpectedViolation( "flexpmd114.c.Test.as", new ViolationPosition[] - { new ViolationPosition( 42 ) } ), + { new ViolationPosition( 30 ) } ), new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 47 ) } ), + { new ViolationPosition( 30 ) } ), new ExpectedViolation( "Looping.as", new ViolationPosition[] - { new ViolationPosition( 63 ) } ) }; + { new ViolationPosition( 51 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/VariableNameEndingWithNumericRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/VariableNameEndingWithNumericRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/VariableNameEndingWithNumericRuleTest.java index 41465a7..19f4ecf 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/VariableNameEndingWithNumericRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/VariableNameEndingWithNumericRuleTest.java @@ -21,7 +21,9 @@ import java.util.List; import com.adobe.ac.pmd.rules.core.AbstractAstFlexRuleTest; import com.adobe.ac.pmd.rules.core.AbstractFlexRule; import com.adobe.ac.pmd.rules.core.ViolationPosition; +import org.junit.Ignore; +@Ignore("This test requires test-data that was not donated to Apache") public class VariableNameEndingWithNumericRuleTest extends AbstractAstFlexRuleTest { @Override @@ -29,9 +31,9 @@ public class VariableNameEndingWithNumericRuleTest extends AbstractAstFlexRuleTe { return new ExpectedViolation[] { new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 405 ), - new ViolationPosition( 441 ), - new ViolationPosition( 459 ) } ), + { new ViolationPosition( 388 ), + new ViolationPosition( 424 ), + new ViolationPosition( 442 ) } ), new ExpectedViolation( "src.epg.StateExit_AS2.as", new ViolationPosition[] { new ViolationPosition( 62 ), new ViolationPosition( 63 ), http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/WronglyNamedVariableRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/WronglyNamedVariableRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/WronglyNamedVariableRuleTest.java index e698ae5..70c87cd 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/WronglyNamedVariableRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/naming/WronglyNamedVariableRuleTest.java @@ -25,41 +25,41 @@ public class WronglyNamedVariableRuleTest extends AbstractAstFlexRuleTest @Override protected ExpectedViolation[] getExpectedViolatingFiles() { - return new ExpectedViolation[] + return new ExpectedViolation[] { new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 340 ), - new ViolationPosition( 341 ), - new ViolationPosition( 342 ), - new ViolationPosition( 343 ), - new ViolationPosition( 344 ), - new ViolationPosition( 345 ), - new ViolationPosition( 346 ), - new ViolationPosition( 347 ), - new ViolationPosition( 350 ), - new ViolationPosition( 351 ), - new ViolationPosition( 352 ), - new ViolationPosition( 353 ), - new ViolationPosition( 387 ), - new ViolationPosition( 388 ), - new ViolationPosition( 389 ), - new ViolationPosition( 390 ), - new ViolationPosition( 391 ), - new ViolationPosition( 392 ), - new ViolationPosition( 393 ), - new ViolationPosition( 394 ), - new ViolationPosition( 397 ), - new ViolationPosition( 398 ), - new ViolationPosition( 399 ), - new ViolationPosition( 400 ) } ), + { new ViolationPosition( 323 ), + new ViolationPosition( 324 ), + new ViolationPosition( 325 ), + new ViolationPosition( 326 ), + new ViolationPosition( 327 ), + new ViolationPosition( 328 ), + new ViolationPosition( 329 ), + new ViolationPosition( 330 ), + new ViolationPosition( 333 ), + new ViolationPosition( 334 ), + new ViolationPosition( 335 ), + new ViolationPosition( 336 ), + new ViolationPosition( 370 ), + new ViolationPosition( 371 ), + new ViolationPosition( 372 ), + new ViolationPosition( 373 ), + new ViolationPosition( 374 ), + new ViolationPosition( 375 ), + new ViolationPosition( 376 ), + new ViolationPosition( 377 ), + new ViolationPosition( 380 ), + new ViolationPosition( 381 ), + new ViolationPosition( 382 ), + new ViolationPosition( 383 ) } ), new ExpectedViolation( "GenericType.as", new ViolationPosition[] - { new ViolationPosition( 44 ), - new ViolationPosition( 46 ) } ), + { new ViolationPosition( 32 ), + new ViolationPosition( 34 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.ConfigProxy.as", new ViolationPosition[] - { new ViolationPosition( 42 ) } ), + { new ViolationPosition( 30 ) } ), new ExpectedViolation( "bug.FlexPMD141a.mxml", new ViolationPosition[] - { new ViolationPosition( 40 ) } ), + { new ViolationPosition( 26 ) } ), new ExpectedViolation( "AbstractRowData.as", new ViolationPosition[] - { new ViolationPosition( 52 ) } ) }; + { new ViolationPosition( 40 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/InaccessibleMetaDataRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/InaccessibleMetaDataRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/InaccessibleMetaDataRuleTest.java index dd3062b..42ad1e0 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/InaccessibleMetaDataRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/InaccessibleMetaDataRuleTest.java @@ -27,12 +27,12 @@ public class InaccessibleMetaDataRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "parsley.InaccessibleMetaData.as", new ViolationPosition[] - { new ViolationPosition( 38, 38 ), - new ViolationPosition( 47, 47 ), - new ViolationPosition( 59, 59 ) } ), + { new ViolationPosition( 26, 26 ), + new ViolationPosition( 35, 35 ), + new ViolationPosition( 47, 47 ) } ), new ExpectedViolation( "parsley.InaccessibleMetaDataInternalClass.as", new ViolationPosition[] - { new ViolationPosition( 33, 33 ) } ) }; + { new ViolationPosition( 21, 21 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MessageInterceptorSignatureRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MessageInterceptorSignatureRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MessageInterceptorSignatureRuleTest.java index 497faf3..de3fe0f 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MessageInterceptorSignatureRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MessageInterceptorSignatureRuleTest.java @@ -27,9 +27,9 @@ public class MessageInterceptorSignatureRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "parsley.MessageInterceptorSignature.as", new ViolationPosition[] - { new ViolationPosition( 42, 42 ), - new ViolationPosition( 47, 47 ), - new ViolationPosition( 53, 53 ) } ) }; + { new ViolationPosition( 30, 30 ), + new ViolationPosition( 35, 35 ), + new ViolationPosition( 41, 41 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MismatchedManagedEventRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MismatchedManagedEventRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MismatchedManagedEventRuleTest.java index 95d0736..0c3d358 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MismatchedManagedEventRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MismatchedManagedEventRuleTest.java @@ -27,7 +27,7 @@ public class MismatchedManagedEventRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "parsley.MismatchedManagedEvent.as", new ViolationPosition[] - { new ViolationPosition( 36, 36 ) } ) }; + { new ViolationPosition( 24, 24 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MisplacedMetaDataRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MisplacedMetaDataRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MisplacedMetaDataRuleTest.java index 5097b09..f17b427 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MisplacedMetaDataRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/MisplacedMetaDataRuleTest.java @@ -27,27 +27,7 @@ public class MisplacedMetaDataRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "parsley.MisplacedMetaData.as", new ViolationPosition[] - { new ViolationPosition( 48, 48 ), - new ViolationPosition( 49, 49 ), - new ViolationPosition( 50, 50 ), - new ViolationPosition( 51, 51 ), - new ViolationPosition( 52, 52 ), - new ViolationPosition( 53, 53 ), - new ViolationPosition( 54, 54 ), - new ViolationPosition( 55, 55 ), - new ViolationPosition( 58, 58 ), - new ViolationPosition( 63, 63 ), - new ViolationPosition( 64, 64 ), - new ViolationPosition( 65, 65 ), - new ViolationPosition( 66, 66 ), - new ViolationPosition( 67, 67 ), - new ViolationPosition( 68, 68 ), - new ViolationPosition( 69, 69 ), - new ViolationPosition( 70, 70 ), - new ViolationPosition( 33, 33 ), - new ViolationPosition( 34, 34 ), - new ViolationPosition( 35, 35 ), - new ViolationPosition( 36, 36 ), + { new ViolationPosition( 36, 36 ), new ViolationPosition( 37, 37 ), new ViolationPosition( 38, 38 ), new ViolationPosition( 39, 39 ), @@ -55,8 +35,28 @@ public class MisplacedMetaDataRuleTest extends AbstractAstFlexRuleTest new ViolationPosition( 41, 41 ), new ViolationPosition( 42, 42 ), new ViolationPosition( 43, 43 ), - new ViolationPosition( 44, 44 ), - new ViolationPosition( 45, 45 ), } ) }; + new ViolationPosition( 46, 46 ), + new ViolationPosition( 51, 51 ), + new ViolationPosition( 52, 52 ), + new ViolationPosition( 53, 53 ), + new ViolationPosition( 54, 54 ), + new ViolationPosition( 55, 55 ), + new ViolationPosition( 56, 56 ), + new ViolationPosition( 57, 57 ), + new ViolationPosition( 58, 58 ), + new ViolationPosition( 21, 21 ), + new ViolationPosition( 22, 22 ), + new ViolationPosition( 23, 23 ), + new ViolationPosition( 24, 24 ), + new ViolationPosition( 25, 25 ), + new ViolationPosition( 26, 26 ), + new ViolationPosition( 27, 27 ), + new ViolationPosition( 28, 28 ), + new ViolationPosition( 29, 29 ), + new ViolationPosition( 30, 30 ), + new ViolationPosition( 31, 31 ), + new ViolationPosition( 32, 32 ), + new ViolationPosition( 33, 33 ), } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMessageHandlerTypeAttributeRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMessageHandlerTypeAttributeRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMessageHandlerTypeAttributeRuleTest.java index f6c21ef..73d4934 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMessageHandlerTypeAttributeRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMessageHandlerTypeAttributeRuleTest.java @@ -27,7 +27,7 @@ public class RedundantMessageHandlerTypeAttributeRuleTest extends AbstractAstFle { return new ExpectedViolation[] { new ExpectedViolation( "parsley.RedundantMessageHandlerTypeAttribute.as", new ViolationPosition[] - { new ViolationPosition( 41, 41 ) } ) }; + { new ViolationPosition( 29, 29 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMethodAttributeRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMethodAttributeRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMethodAttributeRuleTest.java index 2dfffc6..1ef87fb 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMethodAttributeRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/RedundantMethodAttributeRuleTest.java @@ -27,7 +27,7 @@ public class RedundantMethodAttributeRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "parsley.RedundantMethodAttribute.as", new ViolationPosition[] - { new ViolationPosition( 41, 41 ) } ) }; + { new ViolationPosition( 29, 29 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/UnknownMetaDataAttributeRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/UnknownMetaDataAttributeRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/UnknownMetaDataAttributeRuleTest.java index ab877f8..5b07e8c 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/UnknownMetaDataAttributeRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/parsley/UnknownMetaDataAttributeRuleTest.java @@ -27,9 +27,9 @@ public class UnknownMetaDataAttributeRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "parsley.UnknownMetaDataAttribute.as", new ViolationPosition[] - { new ViolationPosition( 36, 36 ), - new ViolationPosition( 39, 39 ), - new ViolationPosition( 33, 33 ) } ) }; + { new ViolationPosition( 24, 24 ), + new ViolationPosition( 27, 27 ), + new ViolationPosition( 21, 21 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidDeclarationInLoopRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidDeclarationInLoopRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidDeclarationInLoopRuleTest.java index 7fd164f..ffd1af3 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidDeclarationInLoopRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidDeclarationInLoopRuleTest.java @@ -27,69 +27,69 @@ public class AvoidDeclarationInLoopRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.FlexPMD181.as", new ViolationPosition[] - { new ViolationPosition( 2338 ) } ), + { new ViolationPosition( 2326 ) } ), new ExpectedViolation( "bug.FlexPMD88.as", new ViolationPosition[] - { new ViolationPosition( 48 ) } ), + { new ViolationPosition( 36 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.mxml.IterationsList.mxml", new ViolationPosition[] - { new ViolationPosition( 53 ), - new ViolationPosition( 64 ), - new ViolationPosition( 76 ) } ), + { new ViolationPosition( 39 ), + new ViolationPosition( 50 ), + new ViolationPosition( 62 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.TestResult.as", new ViolationPosition[] - { new ViolationPosition( 136 ), - new ViolationPosition( 150 ) } ), + { new ViolationPosition( 123 ), + new ViolationPosition( 137 ) } ), new ExpectedViolation( "Looping.as", new ViolationPosition[] - { new ViolationPosition( 63 ) } ), + { new ViolationPosition( 51 ) } ), new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 205 ), - new ViolationPosition( 224 ), - new ViolationPosition( 340 ), + { new ViolationPosition( 188 ), + new ViolationPosition( 207 ), + new ViolationPosition( 323 ), + new ViolationPosition( 324 ), + new ViolationPosition( 325 ), + new ViolationPosition( 326 ), + new ViolationPosition( 327 ), + new ViolationPosition( 328 ), + new ViolationPosition( 329 ), + new ViolationPosition( 330 ), + new ViolationPosition( 333 ), + new ViolationPosition( 334 ), + new ViolationPosition( 335 ), + new ViolationPosition( 336 ), new ViolationPosition( 341 ), - new ViolationPosition( 342 ), - new ViolationPosition( 343 ), - new ViolationPosition( 344 ), - new ViolationPosition( 345 ), - new ViolationPosition( 346 ), - new ViolationPosition( 347 ), - new ViolationPosition( 350 ), new ViolationPosition( 351 ), new ViolationPosition( 352 ), new ViolationPosition( 353 ), - new ViolationPosition( 358 ), - new ViolationPosition( 368 ), - new ViolationPosition( 369 ), + new ViolationPosition( 354 ), + new ViolationPosition( 356 ), + new ViolationPosition( 357 ), new ViolationPosition( 370 ), new ViolationPosition( 371 ), + new ViolationPosition( 372 ), new ViolationPosition( 373 ), new ViolationPosition( 374 ), - new ViolationPosition( 387 ), + new ViolationPosition( 375 ), + new ViolationPosition( 376 ), + new ViolationPosition( 377 ), + new ViolationPosition( 380 ), + new ViolationPosition( 381 ), + new ViolationPosition( 382 ), + new ViolationPosition( 383 ), new ViolationPosition( 388 ), - new ViolationPosition( 389 ), - new ViolationPosition( 390 ), - new ViolationPosition( 391 ), - new ViolationPosition( 392 ), - new ViolationPosition( 393 ), - new ViolationPosition( 394 ), - new ViolationPosition( 397 ), new ViolationPosition( 398 ), new ViolationPosition( 399 ), new ViolationPosition( 400 ), - new ViolationPosition( 405 ), - new ViolationPosition( 415 ), - new ViolationPosition( 416 ), - new ViolationPosition( 417 ), - new ViolationPosition( 418 ), - new ViolationPosition( 420 ), - new ViolationPosition( 421 ), - new ViolationPosition( 592 ), - new ViolationPosition( 595 ), - new ViolationPosition( 597 ), - new ViolationPosition( 617 ), - new ViolationPosition( 618 ), - new ViolationPosition( 619 ), - new ViolationPosition( 620 ) } ), + new ViolationPosition( 401 ), + new ViolationPosition( 403 ), + new ViolationPosition( 404 ), + new ViolationPosition( 575 ), + new ViolationPosition( 578 ), + new ViolationPosition( 580 ), + new ViolationPosition( 600 ), + new ViolationPosition( 601 ), + new ViolationPosition( 602 ), + new ViolationPosition( 603 ) } ), new ExpectedViolation( "RadonDataGrid.as", new ViolationPosition[] - { new ViolationPosition( 188 ) } ) }; + { new ViolationPosition( 176 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidInstanciationInLoopRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidInstanciationInLoopRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidInstanciationInLoopRuleTest.java index 9205516..6d2e57a 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidInstanciationInLoopRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidInstanciationInLoopRuleTest.java @@ -27,19 +27,19 @@ public class AvoidInstanciationInLoopRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 255 ), - new ViolationPosition( 282 ), - new ViolationPosition( 289 ) } ), + { new ViolationPosition( 238 ), + new ViolationPosition( 265 ), + new ViolationPosition( 272 ) } ), new ExpectedViolation( "Looping.as", new ViolationPosition[] - { new ViolationPosition( 43 ), - new ViolationPosition( 46 ), - new ViolationPosition( 50 ), + { new ViolationPosition( 31 ), + new ViolationPosition( 34 ), + new ViolationPosition( 38 ), + new ViolationPosition( 44 ), + new ViolationPosition( 47 ), + new ViolationPosition( 51 ), new ViolationPosition( 56 ), new ViolationPosition( 59 ), - new ViolationPosition( 63 ), - new ViolationPosition( 68 ), - new ViolationPosition( 71 ), - new ViolationPosition( 75 ) } ) }; + new ViolationPosition( 63 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathFloorRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathFloorRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathFloorRuleTest.java index 369617a..5e19776 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathFloorRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathFloorRuleTest.java @@ -27,8 +27,8 @@ public class AvoidUsingMathFloorRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 205 ), - new ViolationPosition( 224 ) } ) }; + { new ViolationPosition( 188 ), + new ViolationPosition( 207 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathRoundRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathRoundRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathRoundRuleTest.java index 43b71be..a715931 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathRoundRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/AvoidUsingMathRoundRuleTest.java @@ -27,7 +27,7 @@ public class AvoidUsingMathRoundRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 434 ) } ) }; + { new ViolationPosition( 417 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/BindableClassRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/BindableClassRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/BindableClassRuleTest.java index 3c388d4..51d2ea5 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/BindableClassRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/BindableClassRuleTest.java @@ -19,7 +19,9 @@ package com.adobe.ac.pmd.rules.performance; import com.adobe.ac.pmd.rules.core.AbstractAstFlexRuleTest; import com.adobe.ac.pmd.rules.core.AbstractFlexRule; import com.adobe.ac.pmd.rules.core.ViolationPosition; +import org.junit.Ignore; +@Ignore("This test requires test-data that was not donated to Apache") public class BindableClassRuleTest extends AbstractAstFlexRuleTest { @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CreationPolicySetToAllRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CreationPolicySetToAllRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CreationPolicySetToAllRuleTest.java index ae06bac..8a4c981 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CreationPolicySetToAllRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CreationPolicySetToAllRuleTest.java @@ -27,7 +27,7 @@ public class CreationPolicySetToAllRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "Main.mxml", new ViolationPosition[] - { new ViolationPosition( 36 ) } ) }; + { new ViolationPosition( 22 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CyclomaticComplexityRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CyclomaticComplexityRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CyclomaticComplexityRuleTest.java index 78dd8a6..a96e506 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CyclomaticComplexityRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/CyclomaticComplexityRuleTest.java @@ -27,14 +27,14 @@ public class CyclomaticComplexityRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.FlexPMD181.as", new ViolationPosition[] - { new ViolationPosition( 2194 ), - new ViolationPosition( 2292 ) } ), + { new ViolationPosition( 2182 ), + new ViolationPosition( 2280 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.LongSwitch.as", new ViolationPosition[] - { new ViolationPosition( 39 ) } ), + { new ViolationPosition( 27 ) } ), new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 548 ) } ), + { new ViolationPosition( 531 ) } ), new ExpectedViolation( "RadonDataGrid.as", new ViolationPosition[] - { new ViolationPosition( 160 ) } ) }; + { new ViolationPosition( 148 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DeeplyNestedIfRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DeeplyNestedIfRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DeeplyNestedIfRuleTest.java index 0d03946..12fa3c3 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DeeplyNestedIfRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DeeplyNestedIfRuleTest.java @@ -27,15 +27,15 @@ public class DeeplyNestedIfRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Duane.mxml", new ViolationPosition[] - { new ViolationPosition( 87 ), - new ViolationPosition( 91 ), - new ViolationPosition( 96 ) } ), + { new ViolationPosition( 73 ), + new ViolationPosition( 77 ), + new ViolationPosition( 82 ) } ), new ExpectedViolation( "com.adobe.ac.AbstractRowData.as", new ViolationPosition[] - { new ViolationPosition( 59 ) } ), + { new ViolationPosition( 47 ) } ), new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 578 ), - new ViolationPosition( 576 ), - new ViolationPosition( 584 ) } ) }; + { new ViolationPosition( 561 ), + new ViolationPosition( 559 ), + new ViolationPosition( 567 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DynamicFiltersUsedInPopupTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DynamicFiltersUsedInPopupTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DynamicFiltersUsedInPopupTest.java index e7eeb44..a6318f3 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DynamicFiltersUsedInPopupTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/DynamicFiltersUsedInPopupTest.java @@ -27,10 +27,10 @@ public class DynamicFiltersUsedInPopupTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "filters.MyPopup.as", new ViolationPosition[] - { new ViolationPosition( 37 ) } ), + { new ViolationPosition( 25 ) } ), new ExpectedViolation( "filters.MyPopup.mxml", new ViolationPosition[] - { new ViolationPosition( 41 ), - new ViolationPosition( 44 ) } ) }; + { new ViolationPosition( 27 ), + new ViolationPosition( 30 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/HeavyConstructorRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/HeavyConstructorRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/HeavyConstructorRuleTest.java index 4e767df..71729b3 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/HeavyConstructorRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/HeavyConstructorRuleTest.java @@ -27,15 +27,15 @@ public class HeavyConstructorRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.FlexPMD88.as", new ViolationPosition[] - { new ViolationPosition( 38 ) } ), + { new ViolationPosition( 26 ) } ), new ExpectedViolation( "flexunit.RaoulTest.as", new ViolationPosition[] - { new ViolationPosition( 71 ) } ), + { new ViolationPosition( 59 ) } ), new ExpectedViolation( "PngEncoder.as", new ViolationPosition[] - { new ViolationPosition( 130 ) } ), + { new ViolationPosition( 113 ) } ), new ExpectedViolation( "Looping.as", new ViolationPosition[] - { new ViolationPosition( 39 ) } ), + { new ViolationPosition( 27 ) } ), new ExpectedViolation( "RadonDataGrid.as", new ViolationPosition[] - { new ViolationPosition( 53 ) } ) }; + { new ViolationPosition( 41 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/RecursiveStyleManagerRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/RecursiveStyleManagerRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/RecursiveStyleManagerRuleTest.java index fcef96f..0c361af 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/RecursiveStyleManagerRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/RecursiveStyleManagerRuleTest.java @@ -27,8 +27,8 @@ public class RecursiveStyleManagerRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "GoodComponent.as", new ViolationPosition[] - { new ViolationPosition( 59 ), - new ViolationPosition( 60 ) } ) }; + { new ViolationPosition( 47 ), + new ViolationPosition( 48 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/UseTraceFunctionRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/UseTraceFunctionRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/UseTraceFunctionRuleTest.java index 2e8b45d..a9f181d 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/UseTraceFunctionRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/performance/UseTraceFunctionRuleTest.java @@ -27,12 +27,12 @@ public class UseTraceFunctionRuleTest extends AbstractAstFlexRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "com.adobe.ac.ncss.LongSwitch.as", new ViolationPosition[] - { new ViolationPosition( 125 ) } ), + { new ViolationPosition( 113 ) } ), new ExpectedViolation( "Simple.as", new ViolationPosition[] - { new ViolationPosition( 1 ) } ), + { new ViolationPosition( 19 ) } ), new ExpectedViolation( "com.adobe.ac.ncss.BigImporterModel.as", new ViolationPosition[] - { new ViolationPosition( 74 ), - new ViolationPosition( 75 ) } ) }; + { new ViolationPosition( 62 ), + new ViolationPosition( 63 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowAllSecureDomainRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowAllSecureDomainRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowAllSecureDomainRuleTest.java index e58442e..316640f 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowAllSecureDomainRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowAllSecureDomainRuleTest.java @@ -27,7 +27,7 @@ public class AllowAllSecureDomainRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Security.as", new ViolationPosition[] - { new ViolationPosition( 38 ) } ) }; + { new ViolationPosition( 26 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowInsecureDomainRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowInsecureDomainRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowInsecureDomainRuleTest.java index b802bf5..0440907 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowInsecureDomainRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/AllowInsecureDomainRuleTest.java @@ -27,8 +27,8 @@ public class AllowInsecureDomainRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Security.as", new ViolationPosition[] - { new ViolationPosition( 39 ), - new ViolationPosition( 40 ) } ) }; + { new ViolationPosition( 27 ), + new ViolationPosition( 28 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/InsecureExactSettingsRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/InsecureExactSettingsRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/InsecureExactSettingsRuleTest.java index ef80bbd..251fdc5 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/InsecureExactSettingsRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/InsecureExactSettingsRuleTest.java @@ -27,7 +27,7 @@ public class InsecureExactSettingsRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Security.as", new ViolationPosition[] - { new ViolationPosition( 41 ) } ) }; + { new ViolationPosition( 29 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LSOSecureFalseRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LSOSecureFalseRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LSOSecureFalseRuleTest.java index 83a35c6..221b416 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LSOSecureFalseRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LSOSecureFalseRuleTest.java @@ -27,7 +27,7 @@ public class LSOSecureFalseRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Security.as", new ViolationPosition[] - { new ViolationPosition( 45 ) } ) }; + { new ViolationPosition( 33 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LocalConnectionStarRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LocalConnectionStarRuleTest.java b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LocalConnectionStarRuleTest.java index 97adaf7..1931c9d 100644 --- a/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LocalConnectionStarRuleTest.java +++ b/FlexPMD/flex-pmd-java/flex-pmd-ruleset/src/test/java/com/adobe/ac/pmd/rules/security/LocalConnectionStarRuleTest.java @@ -27,7 +27,7 @@ public class LocalConnectionStarRuleTest extends AbstractRegExpBasedRuleTest { return new ExpectedViolation[] { new ExpectedViolation( "bug.Security.as", new ViolationPosition[] - { new ViolationPosition( 42 ) } ) }; + { new ViolationPosition( 30 ) } ) }; } @Override http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/84658ba5/FlexPMD/pom.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/pom.xml b/FlexPMD/pom.xml index 1796eec..e3b6d2d 100644 --- a/FlexPMD/pom.xml +++ b/FlexPMD/pom.xml @@ -22,6 +22,12 @@ limitations under the License. <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>14</version> + </parent> + <groupId>org.apache.flex.pmd</groupId> <artifactId>flex-pmd</artifactId> <version>1.3-SNAPSHOT</version> @@ -35,47 +41,23 @@ limitations under the License. low-level code audits, so that consultants can focus on higher level architectural issues. It ended up to be rather advanced anti-patterns detector.</description> - <!--distributionManagement> - <site> - <id>flexpmd_mvn_site</id> - <url>${source.local.path}/site/</url> - </site> - <repository> - <id>flexpmd_mvn_repository</id> - <name>Adobe OSS Repository</name> - <url>${source.local.path}/maven-repository/release</url> - </repository> - <snapshotRepository> - <id>flexpmd_mvn_repository_snapshot</id> - <name>Adobe OSS Snapshot Repository</name> - <url>${source.local.path}/maven-repository/snapshot</url> - </snapshotRepository> - </distributionManagement--> - - <!--issueManagement> - <system>JIRA</system> - <url>https://bugs.adobe.com/jira/browse/FLEXPMD</url> - </issueManagement--> - - <!--licenses> - <license> - <name>BSD</name> - <url>http://www.freebsd.org/copyright/license.html</url> - </license> - </licenses--> - - <!--scm> - <connection>scm:svn:http://opensource.adobe.com/svn/opensource/flexpmd/trunk</connection> - <developerConnection>scm:svn:http://opensource.adobe.com/svn/opensource/flexpmd/trunk</developerConnection> - <url>scm:svn:http://opensource.adobe.com/svn/opensource/flexpmd/trunk</url> - </scm--> - - <!--organization> - <name>Adobe Systems Incorporated</name> - <url>http://www.adobe.com</url> - </organization--> - - <properties> + <mailingLists> + <mailingList> + <name>Apache Flex User List</name> + <subscribe>users-subscr...@flex.apache.org</subscribe> + <unsubscribe>users-unsubscr...@flex.apache.org</unsubscribe> + <post>us...@flex.apache.org</post> + <archive>http://mail-archives.apache.org/mod_mbox/flex-users/</archive> + </mailingList> + </mailingLists> + + <scm> + <connection>scm:svn:https://git-wip-us.apache.org/repos/asf/flex-utilities.git</connection> + <developerConnection>scm:svn:https://git-wip-us.apache.org/repos/asf/flex-utilities.git</developerConnection> + <url>https://git-wip-us.apache.org/repos/asf/flex-utilities.git</url> + </scm> + + <properties> <!-- Project properties --> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <source.url>http://opensource.adobe.com/svn/opensource/flexpmd</source.url> @@ -115,7 +97,6 @@ limitations under the License. <flex-mojos-plugin.version>7.1.0-SNAPSHOT</flex-mojos-plugin.version> <ant-run-plugin.version>1.2</ant-run-plugin.version> <maven-dependency-plugin.version>2.0</maven-dependency-plugin.version> - </properties> <developers> @@ -230,7 +211,6 @@ limitations under the License. </modules> <build> - <pluginManagement> <plugins> <plugin> @@ -247,7 +227,6 @@ limitations under the License. </pluginManagement> <plugins> - <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-release-plugin</artifactId> @@ -346,99 +325,8 @@ limitations under the License. </executions> </plugin> </plugins> - </build> - <!--repositories> - <repository> - <id>maven2-repository.dev.java.net</id> - <name>Java.net Repository for Maven</name> - <url>http://download.java.net/maven/2/</url> - </repository> - <repository> - <id>central</id> - <name>maven-central</name> - <url>http://repo1.maven.org/maven2</url> - <releases> - <enabled>true</enabled> - </releases> - <snapshots> - <enabled>false</enabled> - </snapshots> - </repository> - <repository> - <id>dist.codehaus.org</id> - <layout>legacy</layout> - <url>http://dist.codehaus.org/</url> - </repository> - <repository> - <id>apache</id> - <name>Apache repository</name> - <layout>legacy</layout> - <url>http://cvs.apache.org/repository/</url> - </repository> - <repository> - <id>flex-mojos</id> - <url>http://repository.sonatype.org/content/groups/flexgroup</url> - <snapshots> - <enabled>false</enabled> - <checksumPolicy>ignore</checksumPolicy> - </snapshots> - <releases> - <enabled>true</enabled> - <checksumPolicy>ignore</checksumPolicy> - </releases> - </repository> - <repository> - <id>nexus.codehaus</id> - <name>Nexus Codehaus</name> - <url>https://nexus.codehaus.org/content/repositories/releases</url> - <releases> - <enabled>true</enabled> - </releases> - <snapshots> - <enabled>false</enabled> - </snapshots> - </repository> - </repositories> - - <pluginRepositories> - <pluginRepository> - <id>dist.codehaus.org</id> - <releases> - <enabled>true</enabled> - </releases> - <snapshots> - <enabled>true</enabled> - </snapshots> - <name>XDoclet central repository on codehaus</name> - <url>http://dist.codehaus.org</url> - <layout>legacy</layout> - </pluginRepository> - <pluginRepository> - <id>repository.codehaus.org</id> - <releases> - <enabled>true</enabled> - </releases> - <snapshots> - <enabled>true</enabled> - </snapshots> - <name>Central repository on codehaus</name> - <url>http://repository.codehaus.org</url> - </pluginRepository> - <pluginRepository> - <id>mc-release</id> - <name>Local Maven repository of releases</name> - <url>http://mc-repo.googlecode.com/svn/maven2/releases</url> - <snapshots> - <enabled>false</enabled> - </snapshots> - <releases> - <enabled>true</enabled> - </releases> - </pluginRepository> - </pluginRepositories--> - <reporting> <plugins> <plugin>
