Repository: flex-falcon Updated Branches: refs/heads/feature/maven-migration-test 9f046f7d9 -> 388ecdc48
- Fixed tests so failing to start the FlashPlayer (Timeout) will make the test fail Up till now the exception was caught, a stacktrace was output, but due to the exitCode not being returned at all, the exitCode stayed at 0 making the test pass, even if it shouldn't Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/388ecdc4 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/388ecdc4 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/388ecdc4 Branch: refs/heads/feature/maven-migration-test Commit: 388ecdc48c713a9382500511fcfed9da3f4d9caf Parents: 9f046f7 Author: Christofer Dutz <[email protected]> Authored: Tue Apr 19 16:58:13 2016 +0200 Committer: Christofer Dutz <[email protected]> Committed: Tue Apr 19 16:58:13 2016 +0200 ---------------------------------------------------------------------- compiler/src/test/java/as/ASFeatureTestsBase.java | 2 ++ compiler/src/test/java/mxml/tags/MXMLFeatureTestsBase.java | 2 ++ 2 files changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/388ecdc4/compiler/src/test/java/as/ASFeatureTestsBase.java ---------------------------------------------------------------------- diff --git a/compiler/src/test/java/as/ASFeatureTestsBase.java b/compiler/src/test/java/as/ASFeatureTestsBase.java index eede5f5..e6b3773 100644 --- a/compiler/src/test/java/as/ASFeatureTestsBase.java +++ b/compiler/src/test/java/as/ASFeatureTestsBase.java @@ -145,6 +145,8 @@ public class ASFeatureTestsBase catch (Exception e) { e.printStackTrace(); + // If we just print the stacktrace the exitCode is still 0 and the test will pass. + fail("Got exception"); } // Check that the runtime exit code was 0, meaning that no asserts failed. http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/388ecdc4/compiler/src/test/java/mxml/tags/MXMLFeatureTestsBase.java ---------------------------------------------------------------------- diff --git a/compiler/src/test/java/mxml/tags/MXMLFeatureTestsBase.java b/compiler/src/test/java/mxml/tags/MXMLFeatureTestsBase.java index deb1a38..23c3965 100644 --- a/compiler/src/test/java/mxml/tags/MXMLFeatureTestsBase.java +++ b/compiler/src/test/java/mxml/tags/MXMLFeatureTestsBase.java @@ -140,6 +140,8 @@ public class MXMLFeatureTestsBase catch (Exception e) { e.printStackTrace(); + // If we just print the stacktrace the exitCode is still 0 and the test will pass. + fail("Got exception"); } // Check that the runtime exit code was 0, meaning that no asserts failed.
