‘none’ is the default value of border-style, so it shouldn’t affect rendering.
The problem was in CSSContainerUtils.getBorderMetrics():
var borderStyle:Object = ValuesManager.valuesImpl.getValue(object,
"border-style");
borderStyle was evaluated in JS to undefined and the condition that follows:
if (borderStyle == "none")
was not met.
Anyway, I just built FlexJSStore and the layout looks ok to me. I had to
manually copy the assets folder to see the pngs.
From: Alex Harui<mailto:aha...@adobe.com>
Sent: Monday, November 28, 2016 6:38 PM
To: d...@flex.apache.org<mailto:d...@flex.apache.org>;
commits@flex.apache.org<mailto:commits@flex.apache.org>
Subject: Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 -
explicitly set default border to none, so viewports can ignore non-existent
borders.
Are you sure this did not impact any examples?
-Alex
On 11/28/16, 6:45 AM, "yish...@apache.org" <yish...@apache.org> wrote:
>Repository: flex-asjs
>Updated Branches:
> refs/heads/develop 1ae995db3 -> d159d7ed1
>
>
>FLEX-35187 - explicitly set default border to none, so viewports can
>ignore non-existent borders.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/d159d7ed
>Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/d159d7ed
>Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/d159d7ed
>
>Branch: refs/heads/develop
>Commit: d159d7ed1758d0eb631eea272ce0164a36f4dda9
>Parents: 1ae995d
>Author: yishayw <yishayj...@hotmail.com>
>Authored: Mon Nov 28 16:44:57 2016 +0200
>Committer: yishayw <yishayj...@hotmail.com>
>Committed: Mon Nov 28 16:44:57 2016 +0200
>
>----------------------------------------------------------------------
> frameworks/projects/HTML/src/main/resources/defaults.css | 1 +
> 1 file changed, 1 insertion(+)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/d159d7ed/frameworks/
>projects/HTML/src/main/resources/defaults.css
>----------------------------------------------------------------------
>diff --git a/frameworks/projects/HTML/src/main/resources/defaults.css
>b/frameworks/projects/HTML/src/main/resources/defaults.css
>index 9c017e2..a725c0b 100644
>--- a/frameworks/projects/HTML/src/main/resources/defaults.css
>+++ b/frameworks/projects/HTML/src/main/resources/defaults.css
>@@ -26,6 +26,7 @@
> font-family: "Arial";
> font-size: 12px;
> border-width: 1px;
>+ border-style: none;
> }
>
> .flexjs *, . flexjs *:before, . flexjs *:after {
>
