Repository: flink Updated Branches: refs/heads/master c74d8cac2 -> fc0001c85
[FLINK-8769][flip6] do not print error causing exceptions without debugging In DispatcherRestEndpoint and TaskExecutor, there were two places where without errors (running a job inside an IDE) exceptions were logged. While for debugging they may be useful, for normal operation it is enough to print the messages themselves, especially since some more details were already logged before. This closes #5611. Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/fc0001c8 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/fc0001c8 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/fc0001c8 Branch: refs/heads/master Commit: fc0001c8585ff68f1d2568434727b29c8546d909 Parents: c74d8ca Author: Nico Kruber <n...@data-artisans.com> Authored: Thu Mar 1 13:53:21 2018 +0100 Committer: Stefan Richter <s.rich...@data-artisans.com> Committed: Mon Mar 5 12:22:34 2018 +0100 ---------------------------------------------------------------------- .../runtime/dispatcher/DispatcherRestEndpoint.java | 7 ++++++- .../flink/runtime/taskexecutor/TaskExecutor.java | 16 ++++++++++++++-- 2 files changed, 20 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/fc0001c8/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java index b5205ab..9df6dee 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java @@ -120,7 +120,12 @@ public class DispatcherRestEndpoint extends WebMonitorEndpoint<DispatcherGateway // register extension handlers handlers.addAll(webSubmissionExtension.getHandlers()); } catch (FlinkException e) { - log.info("Failed to load web based job submission extension.", e); + if (log.isDebugEnabled()) { + log.debug("Failed to load web based job submission extension.", e); + } else { + log.info("Failed to load web based job submission extension. " + + "Probable reason: flink-runtime-web is not in the classpath."); + } } } else { log.info("Web-based job submission is not enabled."); http://git-wip-us.apache.org/repos/asf/flink/blob/fc0001c8/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java index cab686a..fc69984 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java @@ -913,13 +913,25 @@ public class TaskExecutor extends RpcEndpoint implements TaskExecutorGateway { if (resourceManagerConnection != null) { if (resourceManagerConnection.isConnected()) { - log.info("Close ResourceManager connection {}.", resourceManagerConnection.getResourceManagerId(), cause); + if (log.isDebugEnabled()) { + log.debug("Close ResourceManager connection {}.", + resourceManagerConnection.getResourceManagerId(), cause); + } else { + log.info("Close ResourceManager connection {}.", + resourceManagerConnection.getResourceManagerId()); + } resourceManagerHeartbeatManager.unmonitorTarget(resourceManagerConnection.getResourceManagerId()); ResourceManagerGateway resourceManagerGateway = resourceManagerConnection.getTargetGateway(); resourceManagerGateway.disconnectTaskManager(getResourceID(), cause); } else { - log.info("Terminating registration attempts towards ResourceManager {}.", resourceManagerConnection.getTargetAddress(), cause); + if (log.isDebugEnabled()) { + log.debug("Terminating registration attempts towards ResourceManager {}.", + resourceManagerConnection.getTargetAddress(), cause); + } else { + log.info("Terminating registration attempts towards ResourceManager {}.", + resourceManagerConnection.getTargetAddress()); + } } resourceManagerConnection.close();
