This is an automated email from the ASF dual-hosted git repository. trohrmann pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit ffd1e163dd8adca9ed73f7e8c950ba087c73223e Author: Till Rohrmann <trohrm...@apache.org> AuthorDate: Wed Mar 27 09:20:12 2019 +0100 [hotfix] Fix checkstyle violations in ExecutionGraphDeploymentTest --- .../ExecutionGraphDeploymentTest.java | 29 ++++++---------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphDeploymentTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphDeploymentTest.java index b4cccdc..5ececd6 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphDeploymentTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphDeploymentTest.java @@ -318,7 +318,7 @@ public class ExecutionGraphDeploymentTest extends TestLogger { Tuple2<ExecutionGraph, Map<ExecutionAttemptID, Execution>> graphAndExecutions = setupExecution(v1, 1, v2, 1); ExecutionGraph graph = graphAndExecutions.f0; - + // verify behavior for canceled executions Execution execution1 = graphAndExecutions.f1.values().iterator().next(); @@ -326,15 +326,15 @@ public class ExecutionGraphDeploymentTest extends TestLogger { Map<String, Accumulator<?, ?>> accumulators = new HashMap<>(); accumulators.put("acc", new IntCounter(4)); AccumulatorSnapshot accumulatorSnapshot = new AccumulatorSnapshot(graph.getJobID(), execution1.getAttemptId(), accumulators); - + TaskExecutionState state = new TaskExecutionState(graph.getJobID(), execution1.getAttemptId(), ExecutionState.CANCELED, null, accumulatorSnapshot, ioMetrics); - + graph.updateState(state); - + assertEquals(ioMetrics, execution1.getIOMetrics()); assertNotNull(execution1.getUserAccumulators()); assertEquals(4, execution1.getUserAccumulators().get("acc").getLocalValue()); - + // verify behavior for failed executions Execution execution2 = graphAndExecutions.f1.values().iterator().next(); @@ -365,14 +365,14 @@ public class ExecutionGraphDeploymentTest extends TestLogger { JobVertex v2 = new JobVertex("v2", jid2); Map<ExecutionAttemptID, Execution> executions = setupExecution(v1, 1, v2, 1).f1; - + IOMetrics ioMetrics = new IOMetrics(0, 0, 0, 0, 0, 0.0, 0.0, 0.0, 0.0, 0.0); Map<String, Accumulator<?, ?>> accumulators = Collections.emptyMap(); Execution execution1 = executions.values().iterator().next(); execution1.cancel(); execution1.completeCancelling(accumulators, ioMetrics); - + assertEquals(ioMetrics, execution1.getIOMetrics()); assertEquals(accumulators, execution1.getUserAccumulators()); @@ -540,7 +540,7 @@ public class ExecutionGraphDeploymentTest extends TestLogger { checkJobOffloaded(eg); eg.start(TestingComponentMainThreadExecutorServiceAdapter.forMainThread()); - + eg.setQueuedSchedulingAllowed(false); List<JobVertex> ordered = Arrays.asList(v1, v2); @@ -670,19 +670,6 @@ public class ExecutionGraphDeploymentTest extends TestLogger { new SimpleAckingTaskManagerGateway()); } - @SuppressWarnings("serial") - public static class FailingFinalizeJobVertex extends JobVertex { - - public FailingFinalizeJobVertex(String name, JobVertexID id) { - super(name, id); - } - - @Override - public void finalizeOnMaster(ClassLoader cl) throws Exception { - throw new Exception(); - } - } - private ExecutionGraph createExecutionGraph(Configuration configuration) throws Exception { final ScheduledExecutorService executor = TestingUtils.defaultExecutor();