This is an automated email from the ASF dual-hosted git repository.
jincheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 86fd4b5 [FLINK-12991][python] Correct the implementation of
Catalog.get_table_factory (#8956)
86fd4b5 is described below
commit 86fd4b5722414b0255f9e1a31492824d5ec5b126
Author: dianfu <fudian...@alibaba-inc.com>
AuthorDate: Tue Jul 9 09:19:29 2019 +0800
[FLINK-12991][python] Correct the implementation of
Catalog.get_table_factory (#8956)
---
flink-python/pyflink/table/catalog.py | 9 ---------
flink-python/pyflink/table/tests/test_catalog_completeness.py | 2 +-
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/flink-python/pyflink/table/catalog.py
b/flink-python/pyflink/table/catalog.py
index 081d4c6..a476f66 100644
--- a/flink-python/pyflink/table/catalog.py
+++ b/flink-python/pyflink/table/catalog.py
@@ -54,15 +54,6 @@ class Catalog(object):
"""
return self._j_catalog.getDefaultDatabase()
- def get_table_factory(self):
- """
- Get an optional TableFactory instance that's responsible for
generating source/sink for
- tables stored in this catalog.
-
- :return: An optional TableFactory instance.
- """
- return self._j_catalog.getTableFactory()
-
def list_databases(self):
"""
Get the names of all databases in this catalog.
diff --git a/flink-python/pyflink/table/tests/test_catalog_completeness.py
b/flink-python/pyflink/table/tests/test_catalog_completeness.py
index 40612e5..9474c30 100644
--- a/flink-python/pyflink/table/tests/test_catalog_completeness.py
+++ b/flink-python/pyflink/table/tests/test_catalog_completeness.py
@@ -40,7 +40,7 @@ class
CatalogAPICompletenessTests(PythonAPICompletenessTestCase, unittest.TestCa
@classmethod
def excluded_methods(cls):
# open/close are not needed in Python API as they are used internally
- return {'open', 'close'}
+ return {'open', 'close', 'getTableFactory'}
class CatalogDatabaseAPICompletenessTests(PythonAPICompletenessTestCase,
unittest.TestCase):
