This is an automated email from the ASF dual-hosted git repository. sewen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit 31b45fc6c48dc0503f1c91ce1b6b0b00c6439a02 Author: Stephan Ewen <se...@apache.org> AuthorDate: Wed Aug 4 18:42:00 2021 +0200 [FLINK-23629][tests] Remove redundant file-async and mem-async test runs from EventTimeWindowCheckpointingITCase Because all snapshots are async, the MEM and MEM_ASYNC, as well as FILE and FILE_ASYNC are now the same. This removes unneccessary cases to save testing time. --- .../EventTimeWindowCheckpointingITCase.java | 19 ++++--------------- .../flink/test/checkpointing/LocalRecoveryITCase.java | 6 +++--- 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java index eb66393..eff22b8 100644 --- a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java +++ b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java @@ -111,11 +111,9 @@ public class EventTimeWindowCheckpointingITCase extends TestLogger { enum StateBackendEnum { MEM, FILE, - ROCKSDB_FULLY_ASYNC, + ROCKSDB_FULL, ROCKSDB_INCREMENTAL, ROCKSDB_INCREMENTAL_ZK, - MEM_ASYNC, - FILE_ASYNC } @Parameterized.Parameters(name = "statebackend type ={0}, buffersPerChannel = {1}") @@ -173,24 +171,15 @@ public class EventTimeWindowCheckpointingITCase extends TestLogger { switch (stateBackendEnum) { case MEM: - this.stateBackend = new MemoryStateBackend(MAX_MEM_STATE_SIZE, false); + this.stateBackend = new MemoryStateBackend(MAX_MEM_STATE_SIZE); break; case FILE: { String backups = tempFolder.newFolder().getAbsolutePath(); - this.stateBackend = new FsStateBackend("file://" + backups, false); + this.stateBackend = new FsStateBackend("file://" + backups); break; } - case MEM_ASYNC: - this.stateBackend = new MemoryStateBackend(MAX_MEM_STATE_SIZE, true); - break; - case FILE_ASYNC: - { - String backups = tempFolder.newFolder().getAbsolutePath(); - this.stateBackend = new FsStateBackend("file://" + backups, true); - break; - } - case ROCKSDB_FULLY_ASYNC: + case ROCKSDB_FULL: { setupRocksDB(config, -1, false); break; diff --git a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/LocalRecoveryITCase.java b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/LocalRecoveryITCase.java index 8ef3f7e..b72c5f1 100644 --- a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/LocalRecoveryITCase.java +++ b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/LocalRecoveryITCase.java @@ -34,8 +34,8 @@ import java.util.Arrays; import java.util.Collection; import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum; -import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.FILE_ASYNC; -import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.ROCKSDB_FULLY_ASYNC; +import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.FILE; +import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.ROCKSDB_FULL; import static org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.StateBackendEnum.ROCKSDB_INCREMENTAL_ZK; /** @@ -54,7 +54,7 @@ public class LocalRecoveryITCase extends TestLogger { @Parameterized.Parameters(name = "statebackend type ={0}") public static Collection<StateBackendEnum> parameter() { - return Arrays.asList(ROCKSDB_FULLY_ASYNC, ROCKSDB_INCREMENTAL_ZK, FILE_ASYNC); + return Arrays.asList(ROCKSDB_FULL, ROCKSDB_INCREMENTAL_ZK, FILE); } @Test