bgeng777 commented on a change in pull request #23:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/23#discussion_r814598597
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java
##########
@@ -95,7 +95,7 @@ private JobStatus mergeJobStatus(
if (newStatus == null) {
newStatus = createJobStatus(newJob);
} else {
- newStatus.setState(newJob.getJobState().name());
+ newStatus.setState(JobState.valueOf(newJob.getJobState().name()));
Review comment:
Oh, it doesn't matter. The work is not a waste at all, I may just need
to refine it once we achieve consensus on the state transition. Thanks a lot
for the above review and I will close this PR and may reopen it when
[FLINK-26139](https://issues.apache.org/jira/browse/FLINK-26139) is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
