gyfora commented on a change in pull request #54:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/54#discussion_r825442489
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -140,8 +141,13 @@ public boolean isJobManagerPortReady(Configuration config)
{
final String clusterId =
config.get(KubernetesConfigOptions.CLUSTER_ID);
final String namespace = config.get(KubernetesConfigOptions.NAMESPACE);
final int port = config.getInteger(RestOptions.PORT);
- final String host =
+ String host =
ExternalServiceDecorator.getNamespacedExternalServiceName(clusterId, namespace);
+ if (EnvUtils.get("KUBERNETES_SERVICE_HOST") == null) {
+ // not running in k8s, simplify local development
+ // TODO: make this an operator config and pass that config through
Review comment:
If we are planning to make this configurable I suggest we do it straight
away. Let's not leave TODOs for such minor additions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
