tweise commented on a change in pull request #56:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/56#discussion_r825592037
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##########
@@ -75,12 +80,15 @@ private boolean isApplicationClusterReady(FlinkDeployment
dep) {
}
private void observeJmDeployment(
- FlinkDeployment flinkApp, Context context, Configuration
effectiveConfig) {
+ FlinkDeployment flinkApp,
+ Context context,
+ Configuration effectiveConfig,
+ boolean checkOnReady) {
FlinkDeploymentStatus deploymentStatus = flinkApp.getStatus();
JobManagerDeploymentStatus previousJmStatus =
deploymentStatus.getJobManagerDeploymentStatus();
- if (JobManagerDeploymentStatus.READY == previousJmStatus) {
+ if (JobManagerDeploymentStatus.READY == previousJmStatus &&
!checkOnReady) {
Review comment:
Rather than adding the flag, this can be moved into observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
