bgeng777 commented on pull request #131: URL: https://github.com/apache/flink-kubernetes-operator/pull/131#issuecomment-1085896373
> Looks good, one minor thing we still need to change is in the: > > `org.apache.flink.kubernetes.operator.config.Mode` logic. > > We need to make sure to get the mode based on the last-reconciled spec if there is one. We do not allow mode switching but this is only enforced in the validation phase. @gyfora My bad for ignoring the `Mode` when fetching an `Observer` instance. I have updated the `getMode(flinkApp)` to make sure it returns correct mode when last-reconciled spec exists. Also add a dedicated test to verify the `Mode` is selected correctly for observation when operator mode is changed wrongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
