This is an automated email from the ASF dual-hosted git repository. dianfu pushed a commit to branch release-1.15 in repository https://gitbox.apache.org/repos/asf/flink.git
commit e379f3e1969037dd9aec6abf771fe22c5627b168 Author: Dian Fu <dia...@apache.org> AuthorDate: Thu Apr 7 19:55:03 2022 +0800 [hotfix][python] Remove nosiy warnings --- .../java/org/apache/flink/client/python/PythonDriverOptions.java | 6 +++--- .../main/java/org/apache/flink/client/python/PythonEnvUtils.java | 6 +++--- .../api/runners/python/beam/SimpleStateRequestHandler.java | 4 ++-- .../org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java | 7 ------- 4 files changed, 8 insertions(+), 15 deletions(-) diff --git a/flink-python/src/main/java/org/apache/flink/client/python/PythonDriverOptions.java b/flink-python/src/main/java/org/apache/flink/client/python/PythonDriverOptions.java index bec0889d05b..792af77b421 100644 --- a/flink-python/src/main/java/org/apache/flink/client/python/PythonDriverOptions.java +++ b/flink-python/src/main/java/org/apache/flink/client/python/PythonDriverOptions.java @@ -29,11 +29,11 @@ import static java.util.Objects.requireNonNull; /** Options for the {@link PythonDriver}. */ final class PythonDriverOptions { - @Nullable private String entryPointModule; + @Nullable private final String entryPointModule; - @Nullable private String entryPointScript; + @Nullable private final String entryPointScript; - @Nonnull private List<String> programArgs; + @Nonnull private final List<String> programArgs; @Nullable String getEntryPointModule() { diff --git a/flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java b/flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java index ca7d9907c8b..261aa82dc76 100644 --- a/flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java +++ b/flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java @@ -484,9 +484,9 @@ final class PythonEnvUtils { /** The shutdown hook used to destroy the Python process. */ public static class PythonProcessShutdownHook extends Thread { - private Process process; - private GatewayServer gatewayServer; - private String tmpDir; + private final Process process; + private final GatewayServer gatewayServer; + private final String tmpDir; public PythonProcessShutdownHook( Process process, GatewayServer gatewayServer, String tmpDir) { diff --git a/flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/SimpleStateRequestHandler.java b/flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/SimpleStateRequestHandler.java index ba42dc4d385..5eef9b7a427 100644 --- a/flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/SimpleStateRequestHandler.java +++ b/flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/SimpleStateRequestHandler.java @@ -105,8 +105,8 @@ public class SimpleStateRequestHandler implements StateRequestHandler { BeamFnApi.StateGetResponse.newBuilder() .setData(ByteString.copyFrom(new byte[] {NOT_EMPTY_FLAG})); - private final TypeSerializer keySerializer; - private final TypeSerializer namespaceSerializer; + private final TypeSerializer<?> keySerializer; + private final TypeSerializer<?> namespaceSerializer; private final TypeSerializer<byte[]> valueSerializer; private final KeyedStateBackend keyedStateBackend; diff --git a/flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java b/flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java index 8d7a83246fc..29abc5e561e 100644 --- a/flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java +++ b/flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/PythonTypeUtils.java @@ -64,7 +64,6 @@ import java.io.Serializable; import java.math.BigDecimal; import java.math.RoundingMode; import java.sql.Time; -import java.util.TimeZone; /** * Utilities for converting Flink logical types, such as convert it to the related TypeSerializer or @@ -75,12 +74,6 @@ public final class PythonTypeUtils { private static final String EMPTY_STRING = ""; - /** The local time zone. */ - private static final TimeZone LOCAL_TZ = TimeZone.getDefault(); - - /** The number of milliseconds in a day. */ - private static final long MILLIS_PER_DAY = 86400000L; // = 24 * 60 * 60 * 1000 - public static FlinkFnApi.Schema.FieldType toProtoType(LogicalType logicalType) { return logicalType.accept(new PythonTypeUtils.LogicalTypeToProtoTypeConverter()); }