This is an automated email from the ASF dual-hosted git repository. martijnvisser pushed a commit to branch v3.0 in repository https://gitbox.apache.org/repos/asf/flink-connector-jdbc.git
commit add30f3f66f317f0ee956f1c06288a9d7a10a08c Author: Martijn Visser <martijnvis...@apache.org> AuthorDate: Wed Dec 14 13:53:04 2022 +0100 [hotfix][Archunit] Add Archunit rule violations --- .../archunit-violations/0153ac9e-50d0-4645-8ad1-5b1f5d38436d | 7 +++++++ .../archunit-violations/4c4d0bb9-5422-4240-9569-e77248b0b7fe | 0 .../archunit-violations/67df540f-d720-42ac-9a46-1293230c1792 | 0 .../archunit-violations/8c0718f9-e5f7-4ef8-8439-5cbc7a57b1cc | 0 .../archunit-violations/c9b43363-463e-41ff-9527-4d045c212e85 | 2 ++ .../archunit-violations/d583321a-88f8-4f9b-a50c-b584fbf051a2 | 0 flink-connector-jdbc/archunit-violations/stored.rules | 10 ++++++++-- 7 files changed, 17 insertions(+), 2 deletions(-) diff --git a/flink-connector-jdbc/archunit-violations/0153ac9e-50d0-4645-8ad1-5b1f5d38436d b/flink-connector-jdbc/archunit-violations/0153ac9e-50d0-4645-8ad1-5b1f5d38436d new file mode 100644 index 0000000..4f453d5 --- /dev/null +++ b/flink-connector-jdbc/archunit-violations/0153ac9e-50d0-4645-8ad1-5b1f5d38436d @@ -0,0 +1,7 @@ +org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions.builder(): Returned leaf type org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions$JDBCExactlyOnceOptionsBuilder does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.JdbcExecutionOptions.builder(): Returned leaf type org.apache.flink.connector.jdbc.JdbcExecutionOptions$Builder does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.catalog.JdbcCatalog.getInternal(): Returned leaf type org.apache.flink.connector.jdbc.catalog.AbstractJdbcCatalog does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.dialect.AbstractDialect.decimalPrecisionRange(): Returned leaf type org.apache.flink.connector.jdbc.dialect.AbstractDialect$Range does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.dialect.AbstractDialect.timestampPrecisionRange(): Returned leaf type org.apache.flink.connector.jdbc.dialect.AbstractDialect$Range does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.xa.XaSinkStateHandler.load(org.apache.flink.runtime.state.FunctionInitializationContext): Returned leaf type org.apache.flink.connector.jdbc.xa.JdbcXaSinkFunctionState does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.xa.XaSinkStateHandler.store(org.apache.flink.connector.jdbc.xa.JdbcXaSinkFunctionState): Argument leaf type org.apache.flink.connector.jdbc.xa.JdbcXaSinkFunctionState does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated \ No newline at end of file diff --git a/flink-connector-jdbc/archunit-violations/4c4d0bb9-5422-4240-9569-e77248b0b7fe b/flink-connector-jdbc/archunit-violations/4c4d0bb9-5422-4240-9569-e77248b0b7fe new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/67df540f-d720-42ac-9a46-1293230c1792 b/flink-connector-jdbc/archunit-violations/67df540f-d720-42ac-9a46-1293230c1792 new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/8c0718f9-e5f7-4ef8-8439-5cbc7a57b1cc b/flink-connector-jdbc/archunit-violations/8c0718f9-e5f7-4ef8-8439-5cbc7a57b1cc new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/c9b43363-463e-41ff-9527-4d045c212e85 b/flink-connector-jdbc/archunit-violations/c9b43363-463e-41ff-9527-4d045c212e85 new file mode 100644 index 0000000..400c942 --- /dev/null +++ b/flink-connector-jdbc/archunit-violations/c9b43363-463e-41ff-9527-4d045c212e85 @@ -0,0 +1,2 @@ +Class <org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions> does not reside in a package 'org.apache.flink..table' in (JdbcConnectorOptions.java:0) +org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions does not satisfy: annotated with @PublicEvolving or annotated with @Public \ No newline at end of file diff --git a/flink-connector-jdbc/archunit-violations/d583321a-88f8-4f9b-a50c-b584fbf051a2 b/flink-connector-jdbc/archunit-violations/d583321a-88f8-4f9b-a50c-b584fbf051a2 new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/stored.rules b/flink-connector-jdbc/archunit-violations/stored.rules index ee4778c..7247323 100644 --- a/flink-connector-jdbc/archunit-violations/stored.rules +++ b/flink-connector-jdbc/archunit-violations/stored.rules @@ -1,4 +1,10 @@ # -#Thu Jul 28 14:21:00 CST 2022 -Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=0f94f11b-9bc8-445a-8be8-e7dfd8a384b0 +#Wed Dec 14 13:50:46 CET 2022 +Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @Public\ must\ be\ annotated\ with\ @Public.=4c4d0bb9-5422-4240-9569-e77248b0b7fe +Connector\ production\ code\ must\ not\ depend\ on\ non-public\ API\ outside\ of\ connector\ packages=67df540f-d720-42ac-9a46-1293230c1792 ITCASE\ tests\ should\ use\ a\ MiniCluster\ resource\ or\ extension=6b9ab1b0-c14d-4667-bab5-407b81fba98b +Production\ code\ must\ not\ call\ methods\ annotated\ with\ @VisibleForTesting=d583321a-88f8-4f9b-a50c-b584fbf051a2 +Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=0f94f11b-9bc8-445a-8be8-e7dfd8a384b0 +Options\ for\ connectors\ and\ formats\ should\ reside\ in\ a\ consistent\ package\ and\ be\ public\ API.=c9b43363-463e-41ff-9527-4d045c212e85 +Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @PublicEvolving\ must\ be\ annotated\ with\ @Public(Evolving).=0153ac9e-50d0-4645-8ad1-5b1f5d38436d +Classes\ in\ API\ packages\ should\ have\ at\ least\ one\ API\ visibility\ annotation.=8c0718f9-e5f7-4ef8-8439-5cbc7a57b1cc