This is an automated email from the ASF dual-hosted git repository.

guoweijie pushed a commit to branch release-1.17
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.17 by this push:
     new 6eb213d9093 [FLINK-31420][test] Fix unstable test 
ThreadInfoRequestCoordinatorTest#testShutDown.
6eb213d9093 is described below

commit 6eb213d9093d90a7bd91801abfb822edf51f90bb
Author: Weijie Guo <res...@163.com>
AuthorDate: Mon Mar 13 23:09:08 2023 +0800

    [FLINK-31420][test] Fix unstable test 
ThreadInfoRequestCoordinatorTest#testShutDown.
    
    testShutDown using two gateways contains a timeout gateway but expected all 
request futures not done before shutdown. If the timeout reached, this future 
will be failed, result in request future to be done.
---
 .../webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java       | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
 
b/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
index f937ccd1c5d..936fc4eaa67 100644
--- 
a/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
+++ 
b/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
@@ -182,7 +182,9 @@ public class ThreadInfoRequestCoordinatorTest extends 
TestLogger {
         Map<ImmutableSet<ExecutionAttemptID>, 
CompletableFuture<TaskExecutorThreadInfoGateway>>
                 executionWithGateways =
                         createMockSubtaskWithGateways(
-                                CompletionType.SUCCESSFULLY, 
CompletionType.TIMEOUT);
+                                // request future will only be completed after 
all gateways
+                                // successfully return thread infos.
+                                CompletionType.SUCCESSFULLY, 
CompletionType.NEVER_COMPLETE);
 
         List<CompletableFuture<VertexThreadInfoStats>> requestFutures = new 
ArrayList<>();
 

Reply via email to