This is an automated email from the ASF dual-hosted git repository. panyuepeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit 5c2a4ccb91ea8f6c8925c3f8cffa9078a966c5e8 Author: Yuepeng Pan <[email protected]> AuthorDate: Thu Apr 9 20:43:09 2026 +0800 [hotfix][test] Move some auto-closable variables into try-block to manage the closing of objects for MassiveStringSorting.java and MassiveStringValueSorting.java Co-authored-by: spuru9 <[email protected]> --- .../apache/flink/test/manual/MassiveStringSorting.java | 12 ++---------- .../flink/test/manual/MassiveStringValueSorting.java | 16 ++-------------- 2 files changed, 4 insertions(+), 24 deletions(-) diff --git a/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringSorting.java b/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringSorting.java index 16ffa29f301..88d97ad8533 100644 --- a/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringSorting.java +++ b/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringSorting.java @@ -363,9 +363,7 @@ public class MassiveStringSorting { bld.append(prefix); File f = File.createTempFile("strings", "txt"); - BufferedWriter wrt = null; - try { - wrt = new BufferedWriter(new FileWriter(f)); + try (BufferedWriter wrt = new BufferedWriter(new FileWriter(f))) { for (int i = 0; i < numStrings; i++) { bld.setLength(resetValue); @@ -380,8 +378,6 @@ public class MassiveStringSorting { wrt.write(str); wrt.newLine(); } - } finally { - wrt.close(); } return f; @@ -393,9 +389,7 @@ public class MassiveStringSorting { final StringBuilder bld = new StringBuilder(); File f = File.createTempFile("strings", "txt"); - BufferedWriter wrt = null; - try { - wrt = new BufferedWriter(new FileWriter(f)); + try (BufferedWriter wrt = new BufferedWriter(new FileWriter(f))) { for (int i = 0; i < numStrings; i++) { bld.setLength(0); @@ -420,8 +414,6 @@ public class MassiveStringSorting { wrt.write(str); wrt.newLine(); } - } finally { - wrt.close(); } return f; diff --git a/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java b/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java index 1b3550f71d8..699c95f5739 100644 --- a/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java +++ b/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java @@ -389,9 +389,7 @@ public class MassiveStringValueSorting { bld.append(prefix); File f = File.createTempFile("strings", "txt"); - BufferedWriter wrt = null; - try { - wrt = new BufferedWriter(new FileWriter(f)); + try (BufferedWriter wrt = new BufferedWriter(new FileWriter(f))) { for (int i = 0; i < numStrings; i++) { bld.setLength(resetValue); @@ -406,10 +404,6 @@ public class MassiveStringValueSorting { wrt.write(str); wrt.newLine(); } - } finally { - if (wrt != null) { - wrt.close(); - } } return f; @@ -421,9 +415,7 @@ public class MassiveStringValueSorting { final StringBuilder bld = new StringBuilder(); File f = File.createTempFile("strings", "txt"); - BufferedWriter wrt = null; - try { - wrt = new BufferedWriter(new FileWriter(f)); + try (BufferedWriter wrt = new BufferedWriter(new FileWriter(f))) { for (int i = 0; i < numStrings; i++) { bld.setLength(0); @@ -448,10 +440,6 @@ public class MassiveStringValueSorting { wrt.write(str); wrt.newLine(); } - } finally { - if (wrt != null) { - wrt.close(); - } } return f;
