This is an automated email from the ASF dual-hosted git repository.

wenjin272 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-agents.git


The following commit(s) were added to refs/heads/main by this push:
     new 13d543e3 [hotfix] Fix argument name mismatch in PythonVectorStore. 
(#635)
13d543e3 is described below

commit 13d543e330e76a3b7ad7e0deb97a73ee7ee0368e
Author: Wenjin Xie <[email protected]>
AuthorDate: Sun Apr 19 16:32:09 2026 +0800

    [hotfix] Fix argument name mismatch in PythonVectorStore. (#635)
---
 .../flink/agents/api/vectorstores/python/PythonVectorStore.java     | 6 +++---
 .../python/PythonCollectionManageableVectorStoreTest.java           | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git 
a/api/src/main/java/org/apache/flink/agents/api/vectorstores/python/PythonVectorStore.java
 
b/api/src/main/java/org/apache/flink/agents/api/vectorstores/python/PythonVectorStore.java
index 6718cf7a..62b553ee 100644
--- 
a/api/src/main/java/org/apache/flink/agents/api/vectorstores/python/PythonVectorStore.java
+++ 
b/api/src/main/java/org/apache/flink/agents/api/vectorstores/python/PythonVectorStore.java
@@ -86,7 +86,7 @@ public class PythonVectorStore extends BaseVectorStore 
implements PythonResource
         kwargs.put("documents", pythonDocuments);
 
         if (collection != null) {
-            kwargs.put("collection", collection);
+            kwargs.put("collection_name", collection);
         }
 
         return (List<String>) adapter.callMethod(vectorStore, "add", kwargs);
@@ -115,7 +115,7 @@ public class PythonVectorStore extends BaseVectorStore 
implements PythonResource
             kwargs.put("ids", ids);
         }
         if (collection != null) {
-            kwargs.put("collection", collection);
+            kwargs.put("collection_name", collection);
         }
 
         Object pythonDocuments = adapter.callMethod(vectorStore, "get", 
kwargs);
@@ -132,7 +132,7 @@ public class PythonVectorStore extends BaseVectorStore 
implements PythonResource
             kwargs.put("ids", ids);
         }
         if (collection != null) {
-            kwargs.put("collection", collection);
+            kwargs.put("collection_name", collection);
         }
         adapter.callMethod(vectorStore, "delete", kwargs);
     }
diff --git 
a/api/src/test/java/org/apache/flink/agents/api/vectorstores/python/PythonCollectionManageableVectorStoreTest.java
 
b/api/src/test/java/org/apache/flink/agents/api/vectorstores/python/PythonCollectionManageableVectorStoreTest.java
index d92b7167..3faf1a08 100644
--- 
a/api/src/test/java/org/apache/flink/agents/api/vectorstores/python/PythonCollectionManageableVectorStoreTest.java
+++ 
b/api/src/test/java/org/apache/flink/agents/api/vectorstores/python/PythonCollectionManageableVectorStoreTest.java
@@ -261,7 +261,7 @@ public class PythonCollectionManageableVectorStoreTest {
                         argThat(
                                 kwargs -> {
                                     
assertThat(kwargs).containsKey("documents");
-                                    
assertThat(kwargs).containsKey("collection");
+                                    
assertThat(kwargs).containsKey("collection_name");
                                     
assertThat(kwargs).containsKey("batch_size");
                                     return true;
                                 }));
@@ -294,7 +294,7 @@ public class PythonCollectionManageableVectorStoreTest {
                         argThat(
                                 kwargs -> {
                                     assertThat(kwargs).containsKey("ids");
-                                    
assertThat(kwargs).containsKey("collection");
+                                    
assertThat(kwargs).containsKey("collection_name");
                                     return true;
                                 }));
     }
@@ -317,7 +317,7 @@ public class PythonCollectionManageableVectorStoreTest {
                         argThat(
                                 kwargs -> {
                                     assertThat(kwargs).containsKey("ids");
-                                    
assertThat(kwargs).containsKey("collection");
+                                    
assertThat(kwargs).containsKey("collection_name");
                                     return true;
                                 }));
     }

Reply via email to