This is an automated email from the ASF dual-hosted git repository. snuyanzin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit 0e852ba33e1844bcdb9c32710839c9301b51f0f9 Author: Sergey Nuyanzin <[email protected]> AuthorDate: Sun Jun 21 10:33:13 2026 +0200 [FLINK-39817][table] Do not use deprecated `SqlPrettyWriter` constructor --- .../sql/parser/ExtendedSqlRowTypeNameSpecTest.java | 17 ++++++++++------- .../apache/flink/sql/parser/FlinkDDLDataTypeTest.java | 6 +++++- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/ExtendedSqlRowTypeNameSpecTest.java b/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/ExtendedSqlRowTypeNameSpecTest.java index d67aca371a8..5afac37429c 100644 --- a/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/ExtendedSqlRowTypeNameSpecTest.java +++ b/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/ExtendedSqlRowTypeNameSpecTest.java @@ -92,12 +92,15 @@ class ExtendedSqlRowTypeNameSpecTest { .withParserFactory((SqlParserImplFactory) options.get("parserFactory")); return new SqlPrettyWriter( - new CalciteSqlDialect( - SqlDialect.EMPTY_CONTEXT - .withQuotedCasing(parserConfig.unquotedCasing()) - .withConformance(parserConfig.conformance()) - .withUnquotedCasing(parserConfig.unquotedCasing()) - .withIdentifierQuoteString(parserConfig.quoting().string)), - false); + SqlPrettyWriter.config() + .withDialect( + new CalciteSqlDialect( + SqlDialect.EMPTY_CONTEXT + .withQuotedCasing(parserConfig.unquotedCasing()) + .withConformance(parserConfig.conformance()) + .withUnquotedCasing(parserConfig.unquotedCasing()) + .withIdentifierQuoteString( + parserConfig.quoting().string))) + .withAlwaysUseParentheses(false)); } } diff --git a/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLDataTypeTest.java b/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLDataTypeTest.java index d6ff47750bc..71901fe9de5 100644 --- a/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLDataTypeTest.java +++ b/flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkDDLDataTypeTest.java @@ -546,7 +546,11 @@ class FlinkDDLDataTypeTest { SqlNodeList columns = sqlCreateTable.getColumnList(); assertThat(columns.size()).isEqualTo(1); SqlDataTypeSpec dataTypeSpec = ((SqlRegularColumn) columns.get(0)).getType(); - SqlWriter sqlWriter = new SqlPrettyWriter(factory.createSqlDialect(), false); + SqlWriter sqlWriter = + new SqlPrettyWriter( + SqlPrettyWriter.config() + .withDialect(factory.createSqlDialect()) + .withAlwaysUseParentheses(false)); dataTypeSpec.unparse(sqlWriter, 0, 0); // SqlDataTypeSpec does not take care of the nullable attribute unparse, // So we unparse nullable attribute specifically, this unparsing logic should
