Updated Branches: refs/heads/flume-1.3.0 40af97b9b -> f5f199f38
FLUME-1513: File Channel log close() method should not be synchronized (Hari Shreedharan via Brock Noland) Project: http://git-wip-us.apache.org/repos/asf/flume/repo Commit: http://git-wip-us.apache.org/repos/asf/flume/commit/f5f199f3 Tree: http://git-wip-us.apache.org/repos/asf/flume/tree/f5f199f3 Diff: http://git-wip-us.apache.org/repos/asf/flume/diff/f5f199f3 Branch: refs/heads/flume-1.3.0 Commit: f5f199f38cffc7b4b6672a7242f46dde010eb07c Parents: 40af97b Author: Brock Noland <[email protected]> Authored: Mon Aug 27 13:50:27 2012 -0500 Committer: Brock Noland <[email protected]> Committed: Mon Aug 27 13:51:28 2012 -0500 ---------------------------------------------------------------------- .../java/org/apache/flume/channel/file/Log.java | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flume/blob/f5f199f3/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java ---------------------------------------------------------------------- diff --git a/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java b/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java index 5b39b57..b8f6570 100644 --- a/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java +++ b/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java @@ -493,10 +493,10 @@ class Log { } /** - * Synchronization required since we do not want this - * to be called during a checkpoint. + * Synchronization not required since this method gets the write lock, + * so checkpoint and this method cannot run at the same time. */ - synchronized void close() { + void close() { lockExclusive(); try { open = false;
