This is an automated email from the ASF dual-hosted git repository.
yuxia pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fluss.git
The following commit(s) were added to refs/heads/main by this push:
new 5cc3af7f1 [metric] Optimize the createLogicalScope method by adding
empty string checks to avoid unnecessary delimiter concatenation. (#1363)
5cc3af7f1 is described below
commit 5cc3af7f155355576954be2ec798a01875cd5e89
Author: pisceslj <[email protected]>
AuthorDate: Tue Aug 12 15:54:53 2025 +0800
[metric] Optimize the createLogicalScope method by adding empty string
checks to avoid unnecessary delimiter concatenation. (#1363)
Co-authored-by: lujie64 <[email protected]>
---
.../com/alibaba/fluss/metrics/groups/AbstractMetricGroup.java | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git
a/fluss-common/src/main/java/com/alibaba/fluss/metrics/groups/AbstractMetricGroup.java
b/fluss-common/src/main/java/com/alibaba/fluss/metrics/groups/AbstractMetricGroup.java
index 5017e6eea..83be671c3 100644
---
a/fluss-common/src/main/java/com/alibaba/fluss/metrics/groups/AbstractMetricGroup.java
+++
b/fluss-common/src/main/java/com/alibaba/fluss/metrics/groups/AbstractMetricGroup.java
@@ -163,9 +163,13 @@ public abstract class AbstractMetricGroup implements
MetricGroup {
protected String createLogicalScope(CharacterFilter filter, char
delimiter) {
final String groupName = getGroupName(filter);
- return parent == null
- ? groupName
- : parent.getLogicalScope(filter, delimiter) + delimiter +
groupName;
+ if (parent == null) {
+ return groupName;
+ }
+ if (groupName == null || groupName.isEmpty()) {
+ return parent.getLogicalScope(filter, delimiter);
+ }
+ return parent.getLogicalScope(filter, delimiter) + delimiter +
groupName;
}
/** Return the parent of the metric group. */