This is an automated email from the ASF dual-hosted git repository. jark pushed a commit to branch ci-array-flink in repository https://gitbox.apache.org/repos/asf/fluss.git
commit ac9ca8bff7cf283a8204dcbd5f4ce4445ca3d580 Author: Jark Wu <[email protected]> AuthorDate: Mon Dec 1 22:47:46 2025 +0800 test --- .../org/apache/fluss/row/arrow/ArrowReader.java | 1 + .../fluss/row/arrow/writers/ArrowArrayWriter.java | 21 --------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/fluss-common/src/main/java/org/apache/fluss/row/arrow/ArrowReader.java b/fluss-common/src/main/java/org/apache/fluss/row/arrow/ArrowReader.java index d50eb8fe0..d48821dd4 100644 --- a/fluss-common/src/main/java/org/apache/fluss/row/arrow/ArrowReader.java +++ b/fluss-common/src/main/java/org/apache/fluss/row/arrow/ArrowReader.java @@ -58,6 +58,7 @@ public class ArrowReader { } public void close() { + // TODO??? // Do not close the VectorSchemaRoot here. // The root will be closed when LogRecordReadContext closes. } diff --git a/fluss-common/src/main/java/org/apache/fluss/row/arrow/writers/ArrowArrayWriter.java b/fluss-common/src/main/java/org/apache/fluss/row/arrow/writers/ArrowArrayWriter.java index c5001af56..548c4e956 100644 --- a/fluss-common/src/main/java/org/apache/fluss/row/arrow/writers/ArrowArrayWriter.java +++ b/fluss-common/src/main/java/org/apache/fluss/row/arrow/writers/ArrowArrayWriter.java @@ -45,27 +45,6 @@ public class ArrowArrayWriter extends ArrowFieldWriter { } offset += array.size(); listVector.endValue(rowIndex, array.size()); - - // Fix dataVector valueCount after writing each row - // This ensures VectorUnloader has correct valueCount for all vectors - FieldVector dataVector = listVector.getDataVector(); - if (dataVector != null && offset > 0) { - dataVector.setValueCount(offset); - // Recursively fix nested ListVectors - fixNestedListVectorValueCount(dataVector, offset); - } - } - - private void fixNestedListVectorValueCount(FieldVector vector, int parentCount) { - if (vector instanceof ListVector && parentCount > 0) { - ListVector listVector = (ListVector) vector; - int dataVectorValueCount = listVector.getElementEndIndex(parentCount - 1); - FieldVector dataVector = listVector.getDataVector(); - if (dataVector != null && dataVectorValueCount > 0) { - dataVector.setValueCount(dataVectorValueCount); - fixNestedListVectorValueCount(dataVector, dataVectorValueCount); - } - } } /** Resets the offset counter for reuse. */
