(fluss-rust) branch main updated: chore: Update the InternalRow Trait: get_binary, get_bytes to return &[u8] (#104)

[yuxia]

This is an automated email from the ASF dual-hosted git repository.

yuxia pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fluss-rust.git


The following commit(s) were added to refs/heads/main by this push:
     new c883de5  chore: Update the InternalRow Trait: get_binary, get_bytes to 
return &[u8] (#104)
c883de5 is described below

commit c883de56a116d890fae62f35851c967c035ad872
Author: Kelvin Wu <kelvinyu1...@gmail.com>
AuthorDate: Sun Dec 21 12:44:26 2025 +0800

    chore: Update the InternalRow Trait: get_binary, get_bytes to return &[u8] 
(#104)
---
 bindings/cpp/src/types.rs      |  4 ++--
 crates/fluss/src/row/column.rs |  6 ++----
 crates/fluss/src/row/mod.rs    | 12 ++++++------
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/bindings/cpp/src/types.rs b/bindings/cpp/src/types.rs
index f9404ac..8221f22 100644
--- a/bindings/cpp/src/types.rs
+++ b/bindings/cpp/src/types.rs
@@ -332,12 +332,12 @@ fn core_row_to_ffi_fields(row: &fcore::row::ColumnarRow) 
-> Vec<ffi::FfiDatum> {
             ArrowDataType::Binary => {
                 let mut datum = new_datum(DATUM_TYPE_BYTES);
                 // todo: avoid copy bytes for blob
-                datum.bytes_val = row.get_bytes(i);
+                datum.bytes_val = row.get_bytes(i).to_vec();
                 datum
             }
             ArrowDataType::FixedSizeBinary(len) => {
                 let mut datum = new_datum(DATUM_TYPE_BYTES);
-                datum.bytes_val = row.get_binary(i, *len as usize);
+                datum.bytes_val = row.get_binary(i, *len as usize).to_vec();
                 datum
             }
             ArrowDataType::LargeBinary => {
diff --git a/crates/fluss/src/row/column.rs b/crates/fluss/src/row/column.rs
index 6d47836..20d86c0 100644
--- a/crates/fluss/src/row/column.rs
+++ b/crates/fluss/src/row/column.rs
@@ -156,23 +156,21 @@ impl InternalRow for ColumnarRow {
             .value(self.row_id)
     }
 
-    fn get_binary(&self, pos: usize, _length: usize) -> Vec<u8> {
+    fn get_binary(&self, pos: usize, _length: usize) -> &[u8] {
         self.record_batch
             .column(pos)
             .as_any()
             .downcast_ref::<FixedSizeBinaryArray>()
             .expect("Expected binary array.")
             .value(self.row_id)
-            .to_vec()
     }
 
-    fn get_bytes(&self, pos: usize) -> Vec<u8> {
+    fn get_bytes(&self, pos: usize) -> &[u8] {
         self.record_batch
             .column(pos)
             .as_any()
             .downcast_ref::<BinaryArray>()
             .expect("Expected bytes array.")
             .value(self.row_id)
-            .to_vec()
     }
 }
diff --git a/crates/fluss/src/row/mod.rs b/crates/fluss/src/row/mod.rs
index 909f3b1..dd1dedf 100644
--- a/crates/fluss/src/row/mod.rs
+++ b/crates/fluss/src/row/mod.rs
@@ -66,10 +66,10 @@ pub trait InternalRow {
     // fn get_timestamp_ltz(&self, pos: usize, precision: usize) -> 
TimestampLtz;
 
     /// Returns the binary value at the given position with fixed length
-    fn get_binary(&self, pos: usize, length: usize) -> Vec<u8>;
+    fn get_binary(&self, pos: usize, length: usize) -> &[u8];
 
     /// Returns the binary value at the given position
-    fn get_bytes(&self, pos: usize) -> Vec<u8>;
+    fn get_bytes(&self, pos: usize) -> &[u8];
 }
 
 pub struct GenericRow<'a> {
@@ -132,12 +132,12 @@ impl<'a> InternalRow for GenericRow<'a> {
         self.values.get(pos).unwrap().try_into().unwrap()
     }
 
-    fn get_binary(&self, pos: usize, _length: usize) -> Vec<u8> {
-        self.values.get(pos).unwrap().as_blob().to_vec()
+    fn get_binary(&self, pos: usize, _length: usize) -> &[u8] {
+        self.values.get(pos).unwrap().as_blob()
     }
 
-    fn get_bytes(&self, pos: usize) -> Vec<u8> {
-        self.values.get(pos).unwrap().as_blob().to_vec()
+    fn get_bytes(&self, pos: usize) -> &[u8] {
+        self.values.get(pos).unwrap().as_blob()
     }
 }