This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fory.git
The following commit(s) were added to refs/heads/main by this push:
new d668362e fix(java): row encoder array element serializer created too
late (#2323)
d668362e is described below
commit d668362eb49aea77c5938574f67761597dfcbc04
Author: Steven Schlansker <[email protected]>
AuthorDate: Tue Jun 10 14:21:28 2025 -0700
fix(java): row encoder array element serializer created too late (#2323)
## What does this PR do?
buildEncodeExpression is supposed to set up bean serializers so
buildDecodeExpression can fetch them later. but, if your bean is only in
a List, the array serializer uses a ForEach that defers finding the
serializer until the encode expression is gen'ed, causing
`java.lang.IllegalStateException: beanEncoder should have be added in
serializeForBean()`
---
.../fory/format/encoder/RowEncoderBuilder.java | 2 +-
.../format/encoder/ImplementInterfaceTest.java | 47 ++++++++++++++++++++++
2 files changed, 48 insertions(+), 1 deletion(-)
diff --git
a/java/fory-format/src/main/java/org/apache/fory/format/encoder/RowEncoderBuilder.java
b/java/fory-format/src/main/java/org/apache/fory/format/encoder/RowEncoderBuilder.java
index 7c3a581b..459d5c75 100644
---
a/java/fory-format/src/main/java/org/apache/fory/format/encoder/RowEncoderBuilder.java
+++
b/java/fory-format/src/main/java/org/apache/fory/format/encoder/RowEncoderBuilder.java
@@ -146,8 +146,8 @@ public class RowEncoderBuilder extends
BaseBinaryEncoderBuilder {
ctx.addField(ctx.type(Fory.class), FORY_NAME);
Expression encodeExpr = buildEncodeExpression();
- Expression decodeExpr = buildDecodeExpression();
String encodeCode = encodeExpr.genCode(ctx).code();
+ Expression decodeExpr = buildDecodeExpression();
String decodeCode = decodeExpr.genCode(ctx).code();
ctx.overrideMethod("toRow", encodeCode, BinaryRow.class, Object.class,
ROOT_OBJECT_NAME);
// T fromRow(BinaryRow row);
diff --git
a/java/fory-format/src/test/java/org/apache/fory/format/encoder/ImplementInterfaceTest.java
b/java/fory-format/src/test/java/org/apache/fory/format/encoder/ImplementInterfaceTest.java
index c174748a..82d6284c 100644
---
a/java/fory-format/src/test/java/org/apache/fory/format/encoder/ImplementInterfaceTest.java
+++
b/java/fory-format/src/test/java/org/apache/fory/format/encoder/ImplementInterfaceTest.java
@@ -19,6 +19,8 @@
package org.apache.fory.format.encoder;
+import java.util.Arrays;
+import java.util.List;
import java.util.Optional;
import lombok.Data;
import org.apache.fory.annotation.ForyField;
@@ -211,4 +213,49 @@ public class ImplementInterfaceTest {
final OptionalCustomType deserializedBean = encoder.fromRow(row);
Assert.assertEquals(deserializedBean.f1().get().id, bean1.f1().get().id);
}
+
+ public interface ListInner {
+ int f1();
+ }
+
+ static class ListInnerImpl implements ListInner {
+ private final int f1;
+
+ ListInnerImpl(final int f1) {
+ this.f1 = f1;
+ }
+
+ @Override
+ public int f1() {
+ return f1;
+ }
+ }
+
+ public interface ListOuter {
+ List<ListInner> f1();
+ }
+
+ static class ListOuterImpl implements ListOuter {
+ private final List<ListInner> f1;
+
+ ListOuterImpl(final List<ListInner> f1) {
+ this.f1 = f1;
+ }
+
+ @Override
+ public List<ListInner> f1() {
+ return f1;
+ }
+ }
+
+ @Test
+ public void testListTooLazy() {
+ final ListOuter bean1 = new ListOuterImpl(Arrays.asList(new
ListInnerImpl(42)));
+ final RowEncoder<ListOuter> encoder = Encoders.bean(ListOuter.class);
+ final BinaryRow row = encoder.toRow(bean1);
+ final MemoryBuffer buffer = MemoryUtils.wrap(row.toBytes());
+ row.pointTo(buffer, 0, buffer.size());
+ final ListOuter deserializedBean = encoder.fromRow(row);
+ Assert.assertEquals(deserializedBean.f1().get(0).f1(), 42);
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
