This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fory.git
The following commit(s) were added to refs/heads/main by this push:
new 8c0fdca52 ci: Fix Windows wheel creation (#2511)
8c0fdca52 is described below
commit 8c0fdca522b66bbc650c42ac35756b42996428bc
Author: Emre Şafak <[email protected]>
AuthorDate: Sun Aug 24 23:56:54 2025 -0400
ci: Fix Windows wheel creation (#2511)
## Why?
* Wheels were not created on Windows because it does not use bash by
default
* Once that works, downloading them will fail because
`actions/download-artifact` requires the `run-id` to access artifacts
from different workflows.
## What does this PR do?
* Add `actions: read` permission to release workflow.
* Configure `download-artifact` action to use `run-id` and `pattern` for
downloading wheels from a previous workflow run.
* Enable `merge-multiple` for downloading artifacts.
* Add `shell: bash` to build step in native release workflow.
## Related issues
#2506
---
.github/workflows/build-native-release.yml | 1 +
.github/workflows/release-python.yaml | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/.github/workflows/build-native-release.yml
b/.github/workflows/build-native-release.yml
index f6c43662c..d6f013b96 100644
--- a/.github/workflows/build-native-release.yml
+++ b/.github/workflows/build-native-release.yml
@@ -42,6 +42,7 @@ jobs:
run: ./ci/run_ci.sh install_bazel_windows
shell: bash
- name: Build wheel
+ shell: bash
run: ./ci/deploy.sh build_pyfory
- name: Install and verify wheel
shell: bash
diff --git a/.github/workflows/release-python.yaml
b/.github/workflows/release-python.yaml
index c66d65e70..435b35c7e 100644
--- a/.github/workflows/release-python.yaml
+++ b/.github/workflows/release-python.yaml
@@ -25,6 +25,7 @@ on:
permissions:
contents: read
id-token: write
+ actions: read # for accessing workflow run artifacts
jobs:
publish-wheels:
@@ -35,7 +36,10 @@ jobs:
- name: Download all wheel artifacts
uses: actions/download-artifact@v5
with:
+ run-id: ${{ github.event.workflow_run.id }}
+ pattern: "pyfory-wheels-*"
path: downloaded_wheels
+ merge-multiple: true
- name: Move wheels to a single directory
shell: bash
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
