chaokunyang commented on code in PR #2607:
URL: https://github.com/apache/fory/pull/2607#discussion_r2348211527
##########
go/fory/fory.go:
##########
@@ -24,13 +24,53 @@ import (
"sync"
)
-func NewFory(referenceTracking bool) *Fory {
+// ForyOption represents a configuration option for Fory instances
+type ForyOption func(*Fory)
Review Comment:
Maybe we don't need the Fory prefix.
And please document it that this is the functional options. Not everyone
knows it. And we also need to update the readme for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
