VikingDeng opened a new pull request, #3505: URL: https://github.com/apache/fory/pull/3505
## Why? `compiler/examples/service.fdl` is currently broken as a runnable example. I found this while bringing up the compiler locally and running the documented service example command from the compiler guide. The example currently fails because: 1. the package name used `demo.service`, where `service` is a reserved FDL keyword 2. the reply field used `message` as an identifier, which is also a reserved keyword So the documented example is not actually usable in its current form. ## What does this PR do? - changes the example package from `demo.service` to `demo.greeter` - renames the reply field from `message` to `reply` - updates the compiler guide wording around this example - adds a regression test that compiles the example for Java and Python outputs ## Related issues - N/A ## AI Contribution Checklist - [x] Substantial AI assistance was used in this PR: `yes` - [x] If `yes`, I included a completed [AI Contribution Checklist](https://github.com/apache/fory/blob/main/AI_POLICY.md#9-contributor-checklist-for-ai-assisted-prs) in this PR description and the required `AI Usage Disclosure`. - [x] If `yes`, I can explain and defend all important changes without AI help. - [x] If `yes`, I reviewed AI-assisted code changes line by line before submission. - [x] If `yes`, I ran adequate human verification and recorded evidence. - [x] If `yes`, I added or updated tests and docs where required. - [x] If `yes`, I validated protocol or performance impacts with evidence when applicable. - [x] If `yes`, I verified licensing and provenance compliance. AI Usage Disclosure - substantial_ai_assistance: yes - scope: limited drafting assistance for code/test/doc edits and PR wording after manual reproduction and verification - affected_files_or_subsystems: compiler example schema, compiler docs, compiler tests - human_verification: manually reproduced the original failure on a clean `main` checkout, reviewed all changes line by line, then in my local compiler environment from `compiler/` ran `PYTHONPATH=. python3 -m pytest fory_compiler/tests/test_service_example.py -q` -> `1 passed`; also ran `PYTHONPATH=. python -m fory_compiler compile examples/service.fdl --java_out=/tmp/fory_service_example_java_pr1 --python_out=/tmp/fory_service_example_py_pr1` and verified generation succeeded - performance_verification: N/A - provenance_license_confirmation: Apache-2.0-compatible provenance confirmed; no incompatible third-party code introduced ## Does this PR introduce any user-facing change? - This fixes a broken example and its documentation path, but it does not change a public API or binary protocol. - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
