Geethapranay1 commented on issue #3524:
URL: https://github.com/apache/fory/issues/3524#issuecomment-4144423688
I investigated the asan slowness and it’s dominated by
`//cpp/fory/util:float16_test` (~246s),
specifically `Float16FromFloatTest.SignSymmetryForNonNaNBitPatterns` (large
float32 bit-pattern scan).
I implemented a small change that keeps normal-build coverage, but skips
only this one test under ASAN
(detect ASAN via `__has_feature(address_sanitizer)` / `__SANITIZE_ADDRESS__`
and call `GTEST_SKIP()`).
Local verification:
- `bazel test --config=asan --action_env=CCACHE_DISABLE=1
//cpp/fory/util:float16_test --test_output=all`
`SignSymmetryForNonNaNBitPatterns` shows as [SKIPPED] under asan and
warm-cache elapsed time is ~0.39s.
i have a question do you prefer this targeted approach (skip only the
pathological float16 test under asan),
or would you rather change the asan workflow to run only
`//cpp/fory/serialization:struct_test`, `:smart_ptr_serializer_test`,
`:collection_serializer_test`
(as mentioned in the issue)?
I can proceed with either (or do the targeted change first and a follow-up
workflow change if needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
