thmd commented on issue #3050: URL: https://github.com/apache/fory/issues/3050#issuecomment-4150397775
So Gemini seemed to analyze the code and provided an explanation which matches what I assumed might be the case. Can someone validate that coclusion. Basically ClassChecker is the interface and more flexible, write any logic you want. AllowListChecker is only for package matching. Interesting due to ergonomics for a single package AllowListChecker is more complex to write which lead to my confusion. If there's a complex set of packages to allow or even dynamically modify it, AllowListChecker would be simpler to write, bug-free and modifiable. First call performance of AllowListChecker is better for internal try use but that becomes less relevant due to caching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
