chaokunyang commented on code in PR #3394:
URL: https://github.com/apache/fory/pull/3394#discussion_r3020735309
##########
compiler/fory_compiler/tests/test_javascript_codegen.py:
##########
@@ -428,7 +428,7 @@ def test_javascript_qualified_nested_type_resolved():
output = generate_javascript(source)
# Nested type is flattened to a top-level export
- assert "export interface Inner" in output
+ assert "export interface OuterInner" in output
Review Comment:
We do not accept such concat name style, I let an example in previous
comments, take that as reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
