chaokunyang commented on code in PR #3394: URL: https://github.com/apache/fory/pull/3394#discussion_r3044353185
########## docs/compiler/generated-code.md: ########## @@ -826,24 +870,26 @@ If `option enable_auto_type_id = false;` is set, generated code uses name-based ### Nested Type Shape -| Language | Nested type form | -| -------- | ------------------------------ | -| Java | `Person.PhoneNumber` | -| Python | `Person.PhoneNumber` | -| Rust | `person::PhoneNumber` | -| C++ | `Person::PhoneNumber` | -| Go | `Person_PhoneNumber` (default) | -| C# | `Person.PhoneNumber` | -| Swift | `Person.PhoneNumber` | +| Language | Nested type form | +| ---------- | ------------------------------ | +| Java | `Person.PhoneNumber` | Review Comment: those should be `Person.PhoneNumber` style -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
