chaokunyang commented on PR #1294:
URL: https://github.com/apache/incubator-fury/pull/1294#issuecomment-1875247742

   @LiangliangSui We can use `select` to add options like this:
   ```bazel
   COPTS = select({
       "//:opt": ["-DBAZEL_OPT"],
       "//conditions:default": [],
   }) + select({
       "@bazel_tools//src/conditions:windows": [
           # TODO(mehrdadn): (How to) support dynamic linking?
           "-DRAY_STATIC",
       ],
       "//conditions:default": [
       ],
   }) + select({
       "//:clang-cl": [
           "-Wno-builtin-macro-redefined",  # To get rid of warnings caused by 
deterministic build macros (e.g. #define __DATE__ "redacted")
       ],
       "//conditions:default": [
       ],
   })
   ```
   
   But it's OK to add it in `.bazelrc`. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to