theweipeng commented on PR #1413: URL: https://github.com/apache/incubator-fury/pull/1413#issuecomment-2025070621
> > > One more thing is that do we need to add a int16 magic number at the header? JDK serialization use two bytes, avro use 4 bytes, kryo/protobuf/flatbuffer doesn't add magic number. @theweipeng @PragmaTwice @LiangliangSui @pjfanning > > > > > > I think it would be necessary, we can use the magic number to indicate the protocol version > > There are 4 bits empty in fury header, which can be used to indicate the protocol version too. I have noticed that sometimes, applications may encapsulate the data buffer using a proprietary protocol. On the receiving end, the use of a magic number is helpful for them to identify which protocol is being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
