chaokunyang commented on issue #1409: URL: https://github.com/apache/incubator-fury/issues/1409#issuecomment-2028580971
Great, looks pretty promising! The caller is `org.apache.fury.resolver.MapRefResolver#writeRefOrNull`, would be nice if it can be inlined into this method. I took a look at https://github.com/tommyettinger/assorted-benchmarks/blob/master/jmh/src/main/java/de/heidelberg/pvs/container_bench/FlipMap.java#L207. Would it be possible to seperate the branch less hit into a separate method, so the method body is smaller for inline. JVM has a max 325 bytecode size for inline be default. And in fury, we merged the `put` and `get` together into `putOrGet` to reduce two hash look up into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
