chaokunyang commented on code in PR #1483:
URL: https://github.com/apache/incubator-fury/pull/1483#discussion_r1557455886
##########
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##########
@@ -156,8 +156,17 @@ private MemoryBuffer(long offHeapAddress, int size,
ByteBuffer offHeapBuffer) {
* the memory being released.
* @param streamReader a reader for reading from a stream.
*/
- private MemoryBuffer(
+ public MemoryBuffer(
Review Comment:
We'd better keep it private, the MemoryBuffer should only be created by
factory method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
