pandalee99 opened a new pull request, #1489: URL: https://github.com/apache/incubator-fury/pull/1489
## optimize unsafePutPositiveVarInt bytecode size i think,the code can be reduce something memory the bytecode reduced from 208 to 192 <img width="939" alt="image" src="https://github.com/apache/incubator-fury/assets/46820719/a6a2a6ad-dca9-442f-ac3a-f28c95329bef";> #1462 has been reduced from three variables to two variables, and #1466 is already very few variables, I don't think it can be reduced any more <!-- Describe the purpose of this PR. --> Variable-length coding requires at least one variable determination and one variable storage ## Related issues #1466 <!-- Is there any related issue? Please attach here. - #xxxx0 - #xxxx1 - #xxxx2 --> ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/incubator-fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [x] Does this PR introduce any public API change? - [x] Does this PR introduce any binary protocol compatibility change? ## Benchmark pre <img width="867" alt="image" src="https://github.com/apache/incubator-fury/assets/46820719/56273187-c8cb-4dec-adc8-002437d0841a";> after <img width="939" alt="image" src="https://github.com/apache/incubator-fury/assets/46820719/a6a2a6ad-dca9-442f-ac3a-f28c95329bef";> <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
