chaokunyang commented on code in PR #1492:
URL: https://github.com/apache/incubator-fury/pull/1492#discussion_r1561291038
##########
java/fury-core/src/main/java/org/apache/fury/logging/Slf4jLogger.java:
##########
@@ -25,10 +25,13 @@
public class Slf4jLogger implements Logger {
private static final String FQCN = Slf4jLogger.class.getName();
+ private final boolean isLocationAwareLogger;
+
private final org.slf4j.Logger logger;
public Slf4jLogger(Class<?> cls) {
this.logger = org.slf4j.LoggerFactory.getLogger(cls);
+ this.isLocationAwareLogger = logger instanceof LocationAwareLogger;
Review Comment:
Good optimization!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
