chaokunyang commented on code in PR #1533:
URL: https://github.com/apache/incubator-fury/pull/1533#discussion_r1568449463
##########
java/fury-core/src/main/java/org/apache/fury/Fury.java:
##########
@@ -117,6 +116,7 @@ public final class Fury implements BaseFury {
private Iterator<MemoryBuffer> outOfBandBuffers;
private boolean peerOutOfBandEnabled;
private int depth;
+ private final MemoryBufferManager bufferManager;
Review Comment:
I prefer not, we should reduce callstack and avoid use lambda here to reduce
performance cost. There are alreay several nested call before the real
serialization logic run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
