This is an automated email from the ASF dual-hosted git repository.

suiliangliang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-fury.git


The following commit(s) were added to refs/heads/main by this push:
     new 501c1dca fix(java): make slf4j provided (#1605)
501c1dca is described below

commit 501c1dca07360b7f603b5c055b44687f184ff6e4
Author: Shawn Yang <shawn.ck.y...@gmail.com>
AuthorDate: Mon May 6 14:03:18 2024 +0800

    fix(java): make slf4j provided (#1605)
    
    ## What does this PR do?
    Currently fury-core still carries slf4j dependency:
    
    
![image](https://github.com/apache/incubator-fury/assets/12445254/762798f3-ea0e-4c5d-b218-0286fd4817e9)
    
    
    This PR make slf4j provided:
    ```
    [INFO] --- maven-dependency-plugin:3.4.0:tree (default-cli) @ graalvm_tests 
---
    [INFO] org.apache.fury:graalvm_tests:jar:0.6.0-SNAPSHOT
    [INFO] \- org.apache.fury:fury-core:jar:0.6.0-SNAPSHOT:compile
    [INFO]    \- com.google.guava:guava:jar:32.1.2-jre:compile
    [INFO]       +- com.google.guava:failureaccess:jar:1.0.1:compile
    [INFO]       +- 
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
    [INFO]       +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
    [INFO]       +- org.checkerframework:checker-qual:jar:3.33.0:compile
    [INFO]       +- 
com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
    [INFO]       \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
    [INFO] 
------------------------------------------------------------------------
    
    ```
    
    ## Related issues
    
    <!--
    Is there any related issue? Please attach here.
    
    - #xxxx0
    - #xxxx1
    - #xxxx2
    -->
    
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/incubator-fury/issues/new/choose)
    describing the need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
---
 java/fury-testsuite/pom.xml | 3 ++-
 java/pom.xml                | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/java/fury-testsuite/pom.xml b/java/fury-testsuite/pom.xml
index da322d80..c5d91898 100644
--- a/java/fury-testsuite/pom.xml
+++ b/java/fury-testsuite/pom.xml
@@ -43,6 +43,7 @@
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.testng</groupId>
@@ -118,4 +119,4 @@
     </plugins>
   </build>
 
-</project>
\ No newline at end of file
+</project>
diff --git a/java/pom.xml b/java/pom.xml
index c338522c..3f7f7b5f 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -92,6 +92,7 @@
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-api</artifactId>
         <version>2.0.12</version>
+        <scope>provided</scope>
         <optional>true</optional>
       </dependency>
       <dependency>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org

Reply via email to