chaokunyang commented on code in PR #1612: URL: https://github.com/apache/incubator-fury/pull/1612#discussion_r1594142048
########## docs/specification/xlang_serialization_spec.md: ########## @@ -139,16 +139,17 @@ Fury will write the byte order for that object into the data instead of converti Fury header consists starts one byte: ``` -| 2 bytes | 4 bits | 1 bit | 1 bit | 1 bit | 1 bit | optional 4 bytes | -+--------------+---------------+-------+-------+--------+-------+------------------------------------+ -| magic number | reserved bits | oob | xlang | endian | null | unsigned int for meta start offset | +| 2 bytes | 4 bits | 1 bit | 1 bit | 1 bit | 1 bit | 1 byte | optional 4 bytes | ++--------------+---------------+-------+-------+--------+-------+--------------------------+------------------------------------+ +| magic number | reserved bits | oob | xlang | endian | null | serialization language | unsigned int for meta start offset | Review Comment: `serialization language` looks a little weird, how about removing serialization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
