juliojgd commented on PR #1697: URL: https://github.com/apache/fury/pull/1697#issuecomment-2247646638
Sure. This new throw sentence, not present before:  Makes that (1) is a new code point where a RuntimeException can be thrown (before this change it was not) as it's inside a finally and I can't see a try-catch surrounding it. In addition in (2) there is another new point in code where a RuntimeException can be thrown (before this change the catched exception were swallowed silently) and I can't see a try-catch surrounding it.  For me adding a new point throwing a new RuntimeException that before did not throw it makes part of de API contract, and could lead to problems in clients using the library. I am new to Fury code, maybe I'm wrong. Regards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
