chaokunyang commented on code in PR #1794:
URL: https://github.com/apache/fury/pull/1794#discussion_r1707397347
##########
java/fury-core/src/main/java/org/apache/fury/serializer/collection/ChildContainerSerializers.java:
##########
@@ -149,6 +149,14 @@ public Collection newCollection(MemoryBuffer buffer) {
readAndSetFields(buffer, collection, slotsSerializers);
return collection;
}
+
+ @Override
+ public T copy(T originCollection) {
+ if (slotsSerializers.length == 0) {
+ return super.copy(originCollection);
Review Comment:
This will return an object of super class type, which is not right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
