chaokunyang commented on code in PR #1997: URL: https://github.com/apache/fury/pull/1997#discussion_r1905694840
########## cpp/fury/util/string_util.h: ########## @@ -19,14 +19,86 @@ #pragma once +#include <cstdint> #include <string> +// AVX not included here since some older intel cpu doesn't support avx2 +// but the built wheel for avx2 is same as sse2. +#if defined(__ARM_NEON) || defined(__ARM_NEON__) Review Comment: If It's in cc file, it can't be inlined in other files. Actually we need to move all code in string_util.cc into header file. But that can be left to another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
