chaokunyang commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1922598166
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
from chatgpt:
MSVC and Macros: The MSVC environment automatically defines some macros that
can interfere with your code. One such macro is ERROR, which is commonly
defined within Windows headers or other libraries. When you use ERROR as a name
for an enumeration or variable in your code, it collides with this pre-existing
macro definition, causing syntax errors.
We can use ERR here, for better compatibility, maybe we should define the
enum value with FURY prefix:
```c++
enum class FuryLogLevel {
FURY_DEBUG = -1,
FURY_INFO = 0,
FURY_WARNING = 1,
FURY_ERROR = 2,
FURY_FATAL = 3
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
