chaokunyang commented on code in PR #2012:
URL: https://github.com/apache/fury/pull/2012#discussion_r1929635057


##########
java/fury-core/src/main/java/org/apache/fury/meta/ClassSpec.java:
##########
@@ -22,7 +22,7 @@
 import org.apache.fury.type.TypeUtils;
 
 public class ClassSpec {
-  public final String entireClassName;
+  public String entireClassName;

Review Comment:
   I prefer to keep ClassDef immutable abd return a new ClassDef instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to